With bug 34478, presenting a form page should be a GET request without 'cud-' in the op URL parameter. Additionally, a form that creates, updates or deletes some object should be a POST with the 'cud-' prefix. ill-requests.pl did not do this distinction originally, and still doesn't. It instead works around 'cud-' in the $op to preserve existing functionality. It should be refactored to better distinguish between a GET $op and a POST $op.
Created attachment 176794 [details] [review] Bug 36273: OPAC: WIP This is working, currently built on top of bug 36197 as that was the development that brought this issue to light. Refreshing the following URL with unauthenticatedOPACILLRequest enabled would always create a new ILL request. http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?method=create&stage=form&backend=Standard&type=article&branchcode=CPL&unauthenticated_first_name=Pedro%20Jorge&unauthenticated_last_name=Andrade%20Amorim&unauthenticated_email=pedro.amorim@ptfs-europe.com This patch gets rid of using the get_op_param_deprecation method in the OPAC controller. This creates the needed distinction between 'create' op (show the form) and 'cud-create' op (handle POST form submission) More testing is required.