This is very minor, but I figure I'd report it anyway... When using the batch record modification tool, there is no space between the "Record type" content block and the tabbed "Source of records" block. To recreate: 1. Create a MARC modification template 1.1. Go to Cataloging > MARC modification templates > New template 1.2. Give the template a name (for example, "Hide from OPAC") 1.3. Click Submit 1.4. Click New action 1.5. Add a new action (for example, Update existing or add new field(s) 942 n with value 1) 1.6. Click Add action 2. Go to Cataloging > Batch record modification --> Note that there is no space between the white "Record type" block and the block underneath with the tabs for the record source
I found this in 23.05.
I see this on the Batch record deletion page but not the batch record modification page.
Created attachment 164554 [details] [review] Bug 36295: Space out content blocks in batch record deletion This patch adds a float-clearing line break to the batch record deletion template so that the "Record type" section has visual separation from the record number submission tabs. To test, apply the patch and go to Cataloging -> Batch record deletion. There should be padding between the two sections.
In Chrome I see the missing padding in batch record modification too but not in Firefox. In batch_record_modification.tt the spacing was written as <br><br> but changing it to <br class="clear"/> fixes it for Chrome.
Created attachment 164860 [details] [review] Bug 36295: Space out content blocks in batch record modification This patch adds a float clearing class to a line break in the batch record modification template to fix a spacing issue in Chrome. To test apply the patch and go to Cataloging -> Batch record modification There should be space between the two sections.
Created attachment 164889 [details] [review] Bug 36295: Space out content blocks in batch record deletion This patch adds a float-clearing line break to the batch record deletion template so that the "Record type" section has visual separation from the record number submission tabs. To test, apply the patch and go to Cataloging -> Batch record deletion. There should be padding between the two sections. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 164890 [details] [review] Bug 36295: Space out content blocks in batch record modification This patch adds a float clearing class to a line break in the batch record modification template to fix a spacing issue in Chrome. To test apply the patch and go to Cataloging -> Batch record modification There should be space between the two sections. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Thanks all! Looks much better
Created attachment 165407 [details] [review] Bug 36295: Space out content blocks in batch record deletion This patch adds a float-clearing line break to the batch record deletion template so that the "Record type" section has visual separation from the record number submission tabs. To test, apply the patch and go to Cataloging -> Batch record deletion. There should be padding between the two sections. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 165408 [details] [review] Bug 36295: Space out content blocks in batch record modification This patch adds a float clearing class to a line break in the batch record modification template to fix a spacing issue in Chrome. To test apply the patch and go to Cataloging -> Batch record modification There should be space between the two sections. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Backported to 23.05.x for upcoming 23.05.12