Bug 36315 - ILSDI GetRecord speed improvement
Summary: ILSDI GetRecord speed improvement
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Web services (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Didier Gautheron
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-14 08:57 UTC by Didier Gautheron
Modified: 2024-11-18 18:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This change makes the items.location lookup in the ILSDI GetRecords service use a cached lookup rather than a per-item lookup for location values, which makes the ILSDI service return much more quickly for records with many items.
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 36315: ILSDI GetRecords use AuthorisedValues cache for items.location (1.63 KB, patch)
2024-03-28 14:49 UTC, Didier Gautheron 		Details | Diff | Splinter Review
Bug 36315: ILSDI GetRecords use AuthorisedValues cache for items.location (1.68 KB, patch)
2024-05-25 19:20 UTC, David Nind 		Details | Diff | Splinter Review
Bug 36315: ILSDI GetRecords use AuthorisedValues cache for items.location (1.73 KB, patch)
2024-09-26 15:46 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Didier Gautheron 2024-03-14 08:57:38 UTC 
If there's a lot of items, think serial, ILSDI GetRecord is slow enough that EBSCO timeout.


using the authorized values cache for location help.
Comment 1 Didier Gautheron 2024-03-28 14:49:03 UTC 
Created attachment 164064 [details] [review]
Bug 36315: ILSDI GetRecords use AuthorisedValues cache for items.location

Speedup GetRecords by using Koha cache for items.location authorised value.

Test plan
1) Enable ILS-DI http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ILS-DI
2) Download a record   http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=1
3) Note location_description
4) Apply patch
5) Re download the same record
6) Verify location_description are the same
Comment 2 David Nind 2024-05-25 19:20:22 UTC 
Created attachment 167179 [details] [review]
Bug 36315: ILSDI GetRecords use AuthorisedValues cache for items.location

Speedup GetRecords by using Koha cache for items.location authorised value.

Test plan
1) Enable ILS-DI http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ILS-DI
2) Download a record   http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=1
3) Note location_description
4) Apply patch
5) Re download the same record
6) Verify location_description are the same

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Lucas Gass (lukeg) 2024-09-26 15:46:56 UTC 
Created attachment 171993 [details] [review]
Bug 36315: ILSDI GetRecords use AuthorisedValues cache for items.location

Speedup GetRecords by using Koha cache for items.location authorised value.

Test plan
1) Enable ILS-DI http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ILS-DI
2) Download a record   http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=1
3) Note location_description
4) Apply patch
5) Re download the same record
6) Verify location_description are the same

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-10-21 10:27:04 UTC 
Pushed for 24.11!

Well done everyone, thank you!