Bug 36330 - Fix typo: reseve
Summary: Fix typo: reseve
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Alex Buckley
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2024-03-15 13:17 UTC by Magnus Enger
Modified: 2024-03-29 09:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 36330: Change 'reseve' to 'reserve' (577.98 KB, patch)
2024-03-21 23:45 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 36330: Change 'reseve' to 'reserve' (4.98 KB, patch)
2024-03-21 23:50 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 36330: Change 'reseve' to 'reserve' (5.02 KB, patch)
2024-03-22 16:22 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2024-03-15 13:17:41 UTC
$ grep -rn "reseves" *
installer/data/mysql/updatedatabase.pl:4907:    print "Upgrade to $DBversion done (Added system preference ExpireReservesMaxPickUpDelay, system preference ExpireReservesMaxPickUpDelayCharge, add reseves.charge_if_expired)\n";
misc/cronjobs/holds/cancel_expired_holds.pl:37:This script calls C4::Reserves::CancelExpiredReserves which will find and cancel all expired reseves in the system.
magnus@bilbo ~/code/kohaclone (master)$ grep -rn "reseve" *
installer/data/mysql/kohastructure.sql:2233:  `location` varchar(80) DEFAULT NULL COMMENT 'new shelving location for the item to have while on reseve (optional)',
installer/data/mysql/kohastructure.sql:2236:  `enabled` enum('yes','no') NOT NULL DEFAULT 'no' COMMENT 'if at least one enabled course has this item on reseve, this field will be ''yes'', otherwise it will be ''no''',
installer/data/mysql/updatedatabase.pl:4907:    print "Upgrade to $DBversion done (Added system preference ExpireReservesMaxPickUpDelay, system preference ExpireReservesMaxPickUpDelayCharge, add reseves.charge_if_expired)\n";
Koha/Schema/Result/CourseItem.pm:155:new shelving location for the item to have while on reseve (optional)
Koha/Schema/Result/CourseItem.pm:180:if at least one enabled course has this item on reseve, this field will be 'yes', otherwise it will be 'no'
misc/cronjobs/holds/cancel_expired_holds.pl:37:This script calls C4::Reserves::CancelExpiredReserves which will find and cancel all expired reseves in the system.
Comment 1 Alex Buckley 2024-03-21 23:45:55 UTC Comment hidden (obsolete)
Comment 2 Alex Buckley 2024-03-21 23:50:05 UTC
Created attachment 163656 [details] [review]
Bug 36330: Change 'reseve' to 'reserve'

Test plan:
1. git grep 'reseve'. Notice there are instances of 'reseve'
2. Apply patch
3. Repeat step 1, there should be no instances of 'reseve'

Sponsored-by: Catalyst IT, New Zealand
Comment 3 David Nind 2024-03-22 16:22:30 UTC
Created attachment 163718 [details] [review]
Bug 36330: Change 'reseve' to 'reserve'

Test plan:
1. git grep 'reseve'. Notice there are instances of 'reseve'
2. Apply patch
3. Repeat step 1, there should be no instances of 'reseve'

Sponsored-by: Catalyst IT, New Zealand
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Marcel de Rooy 2024-03-29 09:33:48 UTC
diff --git a/Koha/Schema/Result/CourseItem.pm b/Koha/Schema/Result/CourseItem.pm
index 53a62686e4..435c2db64e 100644
--- a/Koha/Schema/Result/CourseItem.pm
+++ b/Koha/Schema/Result/CourseItem.pm
@@ -152,7 +152,7 @@ a place to store the holdingbranch when item is on course reserve
   is_nullable: 1
   size: 80

-new shelving location for the item to have while on reseve (optional)
+new shelving location for the item to have while on reserve (optional)


This is not allowed.
You should provide a dbrev to update the tables for the adjusted comments in kohastructure.
After that provide a DBIx schema update patch or leave it to the RM.