Bug 36342 - Allow entering date ranges directly in bookings
Summary: Allow entering date ranges directly in bookings
Status: RESOLVED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on: 29002 33703
Blocks:
  Show dependency treegraph
 
Reported: 2024-03-18 13:05 UTC by Martin Renvoize (ashimema)
Modified: 2024-10-23 10:23 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function: bookings


Attachments
Bug 36342: Add Maskito date range support (4.05 KB, patch)
2024-04-23 19:55 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 36342: Add Maskito date range support (4.10 KB, patch)
2024-05-25 19:36 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2024-03-18 13:05:04 UTC
We add input masking to flatpickr in bug 33703 but we explicitly disable it for the range case which is used in bookings.

There are options to support this in the Maskito library too, so we could consider adding it back for bookings inputs too.
Comment 1 Lucas Gass (lukeg) 2024-04-18 14:26:48 UTC
+1. Happy to work on this Martin.
Comment 2 Lucas Gass (lukeg) 2024-04-23 19:55:50 UTC
Created attachment 165441 [details] [review]
Bug 36342: Add Maskito date range support

To test:
1. Make some items bookable by going to catalogue/moredetail.pl?biblionumber=X
2. On the toolbar for that record you should now see "Place booking"
3. Try placing a booking and adding the date range for "Booking dates" manually.
4. Play with the DateFormat system preference to make sure this works for all supported date formats.
Comment 3 David Nind 2024-05-25 19:36:50 UTC
Created attachment 167180 [details] [review]
Bug 36342: Add Maskito date range support

To test:
1. Make some items bookable by going to catalogue/moredetail.pl?biblionumber=X
2. On the toolbar for that record you should now see "Place booking"
3. Try placing a booking and adding the date range for "Booking dates" manually.
4. Play with the DateFormat system preference to make sure this works for all supported date formats.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2024-05-25 19:37:40 UTC
Testing notes (using KTD):

1. Example formats used to enter date range directly for bookings:

05/29/2024 to 05/31/2024
29.05.2024 to 31.05.2024
29/05/2024 to 31/05/2024
2024-05-29 to 2024-05-31
Comment 5 Paul Derscheid 2024-10-23 07:51:58 UTC
Doesn't apply anymore :/