In Item::pickup_locations; instead of setting the default value of $pickup_libraries to Koha::Libraries->search(), that call should only be made if that variable is not set to something else. A rather small and probably that not significant fix in terms of performance, but also an easy thing to fix.
Created attachment 163467 [details] [review] Bug 36362: Only call Koha::Libraries->search() if necessary in Item::pickup_locations To test: 1) Make sure the following tests pass: - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblios.t - db_dependent/Koha/Biblio.t Sponsored-by: Gothenburg University Library
Created attachment 163468 [details] [review] Bug 36362: Only call Koha::Libraries->search() if necessary in Item::pickup_locations To test: 1) Make sure the following tests pass: - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblios.t - db_dependent/Koha/Biblio.t Sponsored-by: Gothenburg University Library
Created attachment 166451 [details] [review] Bug 36362: Only call Koha::Libraries->search() if necessary in Item::pickup_locations To test: 1) Make sure the following tests pass: - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblios.t - db_dependent/Koha/Biblio.t Sponsored-by: Gothenburg University Library Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>