We can get into a scenario what a user cannot stay logged in for more than a single page load. If AutoLocation is enabled without branch IP addresses being set, you will be logged out with every page load.
It looks like branchip has to contain a space to trigger the issue.
Created attachment 163576 [details] [review] Bug 36378: Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly We can get into a scenario what a user cannot stay logged in for more than a single page load. If AutoLocation is enabled with branch IP addresses being set to a space, you will be logged out with every page load. Test Plan: 1) Set your branch ip to a space 2) Enable AutoLocation 3) Restart all the things! 4) Log out 5) Log in 6) Browse to another page 7) You are logged out 8) Apply patch 9) Repeat 1-6 10) You are not logged out!
I think maybe a future enhancement would be to validate the branch ip when it is saved.
Created attachment 163716 [details] [review] Bug 36378: Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly We can get into a scenario what a user cannot stay logged in for more than a single page load. If AutoLocation is enabled with branch IP addresses being set to a space, you will be logged out with every page load. Test Plan: 1) Set your branch ip to a space 2) Enable AutoLocation 3) Restart all the things! 4) Log out 5) Log in 6) Browse to another page 7) You are logged out 8) Apply patch 9) Repeat 1-6 10) You are not logged out! Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Created attachment 166625 [details] [review] Bug 36378: Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly We can get into a scenario what a user cannot stay logged in for more than a single page load. If AutoLocation is enabled with branch IP addresses being set to a space, you will be logged out with every page load. Test Plan: 1) Set your branch ip to a space 2) Enable AutoLocation 3) Restart all the things! 4) Log out 5) Log in 6) Browse to another page 7) You are logged out 8) Apply patch 9) Repeat 1-6 10) You are not logged out! Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I agree.. it would be great to validate this field at a later date and I'm glad to see there's a bug report for that now too. For now, however, this catches the case and resolves the misconfiguration issue. Passing QA
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Backported to 23.05.x for upcoming 23.05.12