Bug 36380 - Filter matches not included in borrowers statistics reports
Summary: Filter matches not included in borrowers statistics reports
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Thibaud Guillot
QA Contact: Emily Lamancusa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-21 08:24 UTC by Thibaud Guillot
Modified: 2024-05-29 08:50 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06


Attachments
Bug 36380 : Add filter value on patron statistics report summary (2.27 KB, patch)
2024-03-21 08:29 UTC, Thibaud Guillot
Details | Diff | Splinter Review
Bug 36380 : Add filter value on patron statistics report summary (2.41 KB, patch)
2024-03-25 10:13 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 36380: Add filter value on patron statistics report summary (2.27 KB, patch)
2024-03-26 07:19 UTC, Thibaud Guillot
Details | Diff | Splinter Review
Bug 36380: Add filter value on patron statistics report summary (2.48 KB, patch)
2024-05-09 17:01 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Thibaud Guillot 2024-03-21 08:24:06 UTC
Hello :)

When you want to run a report based on borrowers, you can select filters (branchcode, categorycode, etc.). The table works well, but it should be preceded by a summary to help you remember the filters used.  But the filter value is missing.
Comment 1 Thibaud Guillot 2024-03-21 08:29:31 UTC
Created attachment 163590 [details] [review]
Bug 36380 : Add filter value on patron statistics report summary

Test plan:
1) Go to reports and select "Patrons"
2) Select some filters (patron category, library,..) and run it
3) Normally you will see filters selected but with blank value like
   "branch code = "
4) Apply this patch
5) Refresh

Sponsored by: BibLibre
Comment 2 Frédéric Demians 2024-03-25 10:13:04 UTC
Created attachment 163783 [details] [review]
Bug 36380 : Add filter value on patron statistics report summary

Test plan:
1) Go to reports and select "Patrons"
2) Select some filters (patron category, library,..) and run it
3) Normally you will see filters selected but with blank value like
   "branch code = "
4) Apply this patch
5) Refresh

Sponsored by: BibLibre

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Comment 3 Katrin Fischer 2024-03-25 16:09:23 UTC
Please run QA tools - it should note that there should not a space in the commit message between colon and number :)
Comment 4 Thibaud Guillot 2024-03-26 07:19:14 UTC
Created attachment 163883 [details] [review]
Bug 36380: Add filter value on patron statistics report summary

Test plan:
1) Go to reports and select "Patrons"
2) Select some filters (patron category, library,..) and run it
3) Normally you will see filters selected but with blank value like
   "branch code = "
4) Apply this patch
5) Refresh

Sponsored by: BibLibre
Comment 5 Thibaud Guillot 2024-03-26 07:20:17 UTC
(In reply to Katrin Fischer from comment #3)
> Please run QA tools - it should note that there should not a space in the
> commit message between colon and number :)

Thanks Katrin for your feedback, this is fixed :)
Comment 6 Emily Lamancusa 2024-05-09 17:01:09 UTC
Created attachment 166470 [details] [review]
Bug 36380: Add filter value on patron statistics report summary

Test plan:
1) Go to reports and select "Patrons"
2) Select some filters (patron category, library,..) and run it
3) Normally you will see filters selected but with blank value like
   "branch code = "
4) Apply this patch
5) Refresh

Sponsored by: BibLibre

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 7 Emily Lamancusa 2024-05-09 17:02:17 UTC
Nice fix! Passing QA
Comment 8 Katrin Fischer 2024-05-10 13:20:15 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 9 Fridolin Somers 2024-05-29 08:50:09 UTC
Pushed to 23.11.x for 23.11.06