Bug 36498 - Allow ability to set display order when adding an item group from item editor
Summary: Allow ability to set display order when adding an item group from item editor
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on: 33639
Blocks:
  Show dependency tree / graph
 
Reported: 2024-04-02 22:20 UTC by Lucas Gass (lukeg)
Modified: 2024-07-26 20:01 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement to item groups allows you to set the order for item groups created when adding a new item. To do this: 1. Scroll down to the 'Add to item group section' at the bottom of the add item form. 2. For the options field, select 'Create new item group'. 3. Add a new group name. 4. Add a number to the new 'Display order' field to set the order. Previously, the order of the groups could only be changed from the item groups tab on the record details page. (To use the item groups feature, enable the EnableItemGroups system preference.)
Version(s) released in:
24.11.00,24.05.02
Circulation function:

Attachments
Bug 36498: Add ability to set item group display order from additem.tt (6.29 KB, patch)
2024-04-02 22:40 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 36498: Add ability to set item group display order from additem.tt (6.34 KB, patch)
2024-04-03 07:40 UTC, David Nind 		Details | Diff | Splinter Review
Bug 36498: Add ability to set item group display order from additem.tt (6.40 KB, patch)
2024-05-17 10:34 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 36498: Tidy cataloguing/additem.pl (38.05 KB, patch)
2024-05-17 10:34 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-04-02 22:20:18 UTC 
Currently you can make an item group from the add item screen but you cannot set the display order.
Comment 1 Lucas Gass (lukeg) 2024-04-02 22:40:19 UTC 
Created attachment 164303 [details] [review]
Bug 36498: Add ability to set item group display order from additem.tt

To test:
1. Apply patch, restart_all
2. System preferences -> EnableItemGroups, set to 'Enable'.
3. Find a record and create at least 1 item group.
4. Go to Add item
5. Scroll to the bottom and look for 'Options' underneath 'Add to item group'
6. In the dropdown select 'Create new item group'
7. There should be fields for 'Name' and 'Display order'.
8. Make sure you can add a new item group with and without a display order set. If no display order is set it should default to 0.
9. Try to add a non numerical display order, you should not be able to.
Comment 2 David Nind 2024-04-03 07:40:59 UTC 
Created attachment 164357 [details] [review]
Bug 36498: Add ability to set item group display order from additem.tt

To test:
1. Apply patch, restart_all
2. System preferences -> EnableItemGroups, set to 'Enable'.
3. Find a record and create at least 1 item group.
4. Go to Add item
5. Scroll to the bottom and look for 'Options' underneath 'Add to item group'
6. In the dropdown select 'Create new item group'
7. There should be fields for 'Name' and 'Display order'.
8. Make sure you can add a new item group with and without a display order set. If no display order is set it should default to 0.
9. Try to add a non numerical display order, you should not be able to.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Kyle M Hall (khall) 2024-05-17 10:34:18 UTC 
Created attachment 166883 [details] [review]
Bug 36498: Add ability to set item group display order from additem.tt

To test:
1. Apply patch, restart_all
2. System preferences -> EnableItemGroups, set to 'Enable'.
3. Find a record and create at least 1 item group.
4. Go to Add item
5. Scroll to the bottom and look for 'Options' underneath 'Add to item group'
6. In the dropdown select 'Create new item group'
7. There should be fields for 'Name' and 'Display order'.
8. Make sure you can add a new item group with and without a display order set. If no display order is set it should default to 0.
9. Try to add a non numerical display order, you should not be able to.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Kyle M Hall (khall) 2024-05-17 10:34:40 UTC 
Created attachment 166884 [details] [review]
Bug 36498: Tidy cataloguing/additem.pl

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Katrin Fischer 2024-06-27 12:06:31 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-07-19 15:25:51 UTC 
Backported to 24.05.x for upcoming 24.05.02
Comment 7 Fridolin Somers 2024-07-22 09:52:05 UTC 
I prefere not to add to oldstable 23.11.x