Libraries with IndependentBranches enabled would still like to place holds on items from other branches if they have canreservefromotherbranches enabled as well.
Created attachment 164376 [details] [review] Bug 36502: Canreservefromotherbranches allows staff to place holds even if independent branches is enabled To test: 1. Enable both the IndependentBranches and canreservefromotherbranches system preferences. 2. Log in to the staff interface with a non-super librarian staff user that has permissions to place holds. 3. Search the catalog for an item. 1. The non-super librarian user should be able to place holds on item from their branch. 2. They should see a “No holds allowed” on items from other branches. 4. Apply the patch and restart_all 5. Repeat step 3 or refresh the page. 1. The non-super librarian can now place holds on items from their branch and other branches. 6. Turn off canreservefromotherbranches 1. The non-super librarian cannot place holds on items from other branches again. 7. Sign off and have a great day! :D
Created attachment 164388 [details] [review] Bug 36502: Canreservefromotherbranches allows staff to place holds even if independent branches is enabled To test: 1. Enable both the IndependentBranches and canreservefromotherbranches system preferences. 2. Log in to the staff interface with a non-super librarian staff user that has permissions to place holds. 3. Search the catalog for an item. 1. The non-super librarian user should be able to place holds on item from their branch. 2. They should see a “No holds allowed” on items from other branches. 4. Apply the patch and restart_all 5. Repeat step 3 or refresh the page. 1. The non-super librarian can now place holds on items from their branch and other branches. 6. Turn off canreservefromotherbranches 1. The non-super librarian cannot place holds on items from other branches again. 7. Sign off and have a great day! :D Signed-off-by: esther <esther@bywatersolutions.com>
Sorry Laura, there's a little more work needed here. We're missing a unit test update (both to fix the failure this introduces and test the new case introduced) * Proving t/db_dependent/Koha/Items.t KO! # Failed test '2 items for hold, filtered by IndependentBranches' # at t/db_dependent/Koha/Items.t line 2068. # got: '6' # expected: '2' # Looks like you failed 1 test of 13. # Failed test 'filter_by_for_hold' # at t/db_dependent/Koha/Items.t line 2078. # Looks like you failed 1 test of 20. t/db_dependent/Koha/Items.t ..