Similar to bug 36432 Koha::Objects depends on Koha::DateUtils, which depends on C4::Context, which depends on Koha::Config::SysPrefs, which depends on Koha::Objects
Created attachment 164431 [details] [review] Bug 36526: Remove circular dependency from Koha::Objects Koha::Objects depends on Koha::DateUtils, which depends on C4::Context, which depends on Koha::Config::SysPrefs, which depends on Koha::Objects Apart from the circular dependency, the dependency on C4::Context alone is problematic as it loads a bunch of modules that are not needed at all in Koha::Objects (YAML::XS and ZOOM for instance). As Koha::Objects is used as a base for a lot of modules, we should take care to only load the minimum required. This patch removes uses of Koha::DateUtils from Koha::Objects. It was only used in Koha::Objects::filter_by_last_update filter_by_last_update now requires that the 'from' and 'to' parameters must be DateTime objects. Previously it would also allow date and datetime strings. This possibility was only used in two places: * misc/cronjobs/cleanup_database.pl * tools/cleanborrowers.pl Now they call dt_from_string first and pass a DateTime object to filter_by_last_update Test plan: 1. Run `perl -cw Koha/Objects.pm`. It should only say: "Koha/Objects.pm syntax OK" without warnings 2. Run `prove t/db_dependent/Koha/Objects.t` 3. Verify that misc/cronjobs/cleanup_database.pl works as before, especially with the options --pseudo-transactions, --pseudo-transactions-from and --pseudo-transactions-to 4. Go to Tools » Batch patron deletion and anonymization, check "Verify you want to anonymize patron checkout history" and enter a date in the text input below. Then click Next and verify that the correct count of borrowers is shown. Click on the "Finish" button and verify that the circulation history has been correctly anonymized See also bug 36432
Created attachment 164432 [details] [review] Bug 36526: Remove circular dependency from Koha::Objects Koha::Objects depends on Koha::DateUtils, which depends on C4::Context, which depends on Koha::Config::SysPrefs, which depends on Koha::Objects Apart from the circular dependency, the dependency on C4::Context alone is problematic as it loads a bunch of modules that are not needed at all in Koha::Objects (YAML::XS and ZOOM for instance). As Koha::Objects is used as a base for a lot of modules, we should take care to only load the minimum required. This patch removes uses of Koha::DateUtils from Koha::Objects. It was only used in Koha::Objects::filter_by_last_update filter_by_last_update now requires that the 'from' and 'to' parameters must be DateTime objects. Previously it would also allow date and datetime strings. This possibility was only used in two places: * misc/cronjobs/cleanup_database.pl * tools/cleanborrowers.pl Now they call dt_from_string first and pass a DateTime object to filter_by_last_update Test plan: 1. Run `perl -cw Koha/Objects.pm`. It should only say: "Koha/Objects.pm syntax OK" without warnings 2. Run `prove t/db_dependent/Koha/Objects.t` 3. Verify that misc/cronjobs/cleanup_database.pl works as before, especially with the options --pseudo-transactions, --pseudo-transactions-from and --pseudo-transactions-to 4. Go to Tools » Batch patron deletion and anonymization, check "Verify you want to anonymize patron checkout history" and enter a date in the text input below. Then click Next and verify that the correct count of borrowers is shown. Click on the "Finish" button and verify that the circulation history has been correctly anonymized See also bug 36432
Created attachment 166104 [details] [review] Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com>
Created attachment 166108 [details] [review] Bug 36526: Remove circular dependency from Koha::Objects Koha::Objects depends on Koha::DateUtils, which depends on C4::Context, which depends on Koha::Config::SysPrefs, which depends on Koha::Objects Apart from the circular dependency, the dependency on C4::Context alone is problematic as it loads a bunch of modules that are not needed at all in Koha::Objects (YAML::XS and ZOOM for instance). As Koha::Objects is used as a base for a lot of modules, we should take care to only load the minimum required. This patch removes uses of Koha::DateUtils from Koha::Objects. It was only used in Koha::Objects::filter_by_last_update filter_by_last_update now requires that the 'from' and 'to' parameters must be DateTime objects. Previously it would also allow date and datetime strings. This possibility was only used in two places: * misc/cronjobs/cleanup_database.pl * tools/cleanborrowers.pl Now they call dt_from_string first and pass a DateTime object to filter_by_last_update Test plan: 1. Run `perl -cw Koha/Objects.pm`. It should only say: "Koha/Objects.pm syntax OK" without warnings 2. Run `prove t/db_dependent/Koha/Objects.t` 3. Verify that misc/cronjobs/cleanup_database.pl works as before, especially with the options --pseudo-transactions, --pseudo-transactions-from and --pseudo-transactions-to 4. Go to Tools » Batch patron deletion and anonymization, check "Verify you want to anonymize patron checkout history" and enter a date in the text input below. Then click Next and verify that the correct count of borrowers is shown. Click on the "Finish" button and verify that the circulation history has been correctly anonymized See also bug 36432 Signed-off-by: Tadeusz Sośnierz <tadeusz@sosnierz.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice improvement here, thanks Julain and Tadeusz. Passing QA
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Doesn't apply cleanly to 23.05.x, no backport.