Bug 36535 - 33568 introduced too many changes in modules without tests
Summary: 33568 introduced too many changes in modules without tests
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords: rel_24_05_candidate
Depends on: 33568
Blocks:
  Show dependency treegraph
 
Reported: 2024-04-05 13:07 UTC by Jonathan Druart
Modified: 2024-04-26 12:17 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00


Attachments
Bug 36535: (bug 33568 follow-up) Add missing tests (15.20 KB, patch)
2024-04-18 11:49 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 36535: (bug 33568 follow-up) Add missing tests (15.24 KB, patch)
2024-04-20 13:01 UTC, David Nind
Details | Diff | Splinter Review
Bug 36535: (bug 33568 follow-up) Add missing tests (15.31 KB, patch)
2024-04-23 09:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 36535: (QA follow-up) Use dt_from_string (2.59 KB, patch)
2024-04-23 09:56 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-04-05 13:07:08 UTC
Bug 33568 introduced a lot of new simple accessors without providing unit tests for them.
Comment 1 Jonathan Druart 2024-04-18 11:49:05 UTC
Created attachment 165080 [details] [review]
Bug 36535: (bug 33568 follow-up) Add missing tests

Bug 33568 introduced a lot of new simple accessors without providing unit tests for them.

Test plan:
All tests modified by this patch should pass

Note that one bug was found! Logic issue in lost/not lost
Comment 2 David Nind 2024-04-20 13:01:10 UTC
Created attachment 165235 [details] [review]
Bug 36535: (bug 33568 follow-up) Add missing tests

Bug 33568 introduced a lot of new simple accessors without providing unit tests for them.

Test plan:
All tests modified by this patch should pass

Note that one bug was found! Logic issue in lost/not lost

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-04-20 13:02:13 UTC
Testing notes (using KTD):

1. Tests pass both before and after:

prove t/db_dependent/Items.t
prove t/db_dependent/Koha/Biblio/ItemGroups.t
prove t/db_dependent/Koha/Courses.t (new test)
prove t/db_dependent/Koha/Item.t
prove t/db_dependent/Koha/Items.t
prove t/db_dependent/api/v1/biblios.t
Comment 4 Martin Renvoize 2024-04-23 09:56:49 UTC
Created attachment 165363 [details] [review]
Bug 36535: (bug 33568 follow-up) Add missing tests

Bug 33568 introduced a lot of new simple accessors without providing unit tests for them.

Test plan:
All tests modified by this patch should pass

Note that one bug was found! Logic issue in lost/not lost

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2024-04-23 09:56:51 UTC
Created attachment 165364 [details] [review]
Bug 36535: (QA follow-up) Use dt_from_string

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2024-04-23 09:57:38 UTC
Great to see these tests coming through, thanks for the follow-up Jonathan!

Passing QA
Comment 7 Katrin Fischer 2024-04-26 12:17:07 UTC
Pushed for 24.05!

Well done everyone, thank you!