Bug 36572 - Cleanup the set library page and avoid extra confirmation step
Summary: Cleanup the set library page and avoid extra confirmation step
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Tomás Cohen Arazi
URL:
Keywords:
Depends on: 36507
Blocks: 30123
  Show dependency treegraph
 
Reported: 2024-04-11 08:26 UTC by Lucas Gass
Modified: 2024-04-12 09:28 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00


Attachments
Bug 36572: Fix and clean-up set library (15.32 KB, patch)
2024-04-11 08:53 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 36572: Fix and clean-up set library (15.39 KB, patch)
2024-04-11 10:38 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 36572: (follow-up) More template clean-up (2.88 KB, patch)
2024-04-11 12:13 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 36572: Fix and clean-up set library (15.44 KB, patch)
2024-04-11 13:40 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 36572: (follow-up) More template clean-up (2.94 KB, patch)
2024-04-11 13:40 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2024-04-11 08:26:16 UTC
While looking at the set-library code I noticed a few things:

-Currently you cannot set your desk/register if you are a superlibrarian. That is my fault due to Bug 36507.

-There is an extra step after changing your branch/desk/register where you need to confirm, before being redirected. This is new behavior and unnecessary.

We can make it better.
Comment 1 Lucas Gass 2024-04-11 08:53:10 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2024-04-11 10:38:25 UTC
Created attachment 164672 [details] [review]
Bug 36572: Fix and clean-up set library

To test:
1. Have 3 staff accounts to test:
  -STAFF A: superlibrarian
  -STAFF B: loggedinlibrary permission
  -STAFF C: no loggedinlibrary or superlibrarian permission
2. Enable 'UseCirculationDesks' and create some desks. (Admin >
   Circulation desks)
3. Enable 'UseCashRegisters' and create some registers ( Admin > Cash
   registers)
4. Use STAFF A ( superlibrarian ) and make sure you can change branch,
   desk and register.
5. Use STAFF B ( loggedinlibrary permission ) and make sure you can
   change branch, desk and register.
6. Use STAFF C ( no loggedinlibrary or superlibrarian permission ) and
   make sure you can change branch, desk and register.
7. Each time you change you should be redirected to the page you were
   previously on.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Lucas Gass 2024-04-11 12:13:59 UTC
Created attachment 164679 [details] [review]
Bug 36572: (follow-up) More template clean-up

Further testing:
1. Turn off UseCirculationDesks, make sure everything still works.
2. Turn off UseCashRegisters, make sure everthing still works.
Comment 4 Tomás Cohen Arazi 2024-04-11 13:40:41 UTC
Created attachment 164706 [details] [review]
Bug 36572: Fix and clean-up set library

To test:
1. Have 3 staff accounts to test:
  -STAFF A: superlibrarian
  -STAFF B: loggedinlibrary permission
  -STAFF C: no loggedinlibrary or superlibrarian permission
2. Enable 'UseCirculationDesks' and create some desks. (Admin >
   Circulation desks)
3. Enable 'UseCashRegisters' and create some registers ( Admin > Cash
   registers)
4. Use STAFF A ( superlibrarian ) and make sure you can change branch,
   desk and register.
5. Use STAFF B ( loggedinlibrary permission ) and make sure you can
   change branch, desk and register.
6. Use STAFF C ( no loggedinlibrary or superlibrarian permission ) and
   make sure you can change branch, desk and register.
7. Each time you change you should be redirected to the page you were
   previously on.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Tomás Cohen Arazi 2024-04-11 13:40:44 UTC
Created attachment 164707 [details] [review]
Bug 36572: (follow-up) More template clean-up

Further testing:
1. Turn off UseCirculationDesks, make sure everything still works.
2. Turn off UseCashRegisters, make sure everthing still works.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Katrin Fischer 2024-04-12 09:28:32 UTC
Pushed for 24.05!

Well done everyone, thank you!