For MARC 21, canceled/invalid ISBNs (subfield 020 $z) are not being indexed in Elasticsearch (search fields identifier-standard and isbn), but it is for UNIMARC (subfield 010 $z). As a result, a user searching for such an ISBN (e.g. with wrong checksum--and therefor put in 020 $z) will not find the record in the catalogue.
Created attachment 164667 [details] [review] Bug 36574: Canceled/invalid ISBN not indexed by ES for MARC 21 For MARC 21, canceled/invalid ISBNs (subfield 020 $z) are not being indexed in Elasticsearch (search fields identifier-standard and isbn), but it is for UNIMARC (subfield 010 $z). As a result, a user searching for such an ISBN (e.g. with wrong checksum--and therefor put in 020 $z) will not find the record in the catalogue. Test plan ========= 0. Have a test installation with Elasticsearch. 1. In ktd with its test data, make a biblio search for a cancelled ISBN e.g. 9780007269854. You will get no results. 2. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 3. Repeat the test. You should get "The ice princess / Camilla Läckberg".
Created attachment 164778 [details] Revert "Bug 36574: Canceled/invalid ISBN not indexed by ES for MARC 21" This reverts commit 019e80dbbeaccfae732c59c5590da6e5a29f329b.
(In reply to Roman Dolny from comment #2) > Created attachment 164778 [details] [review] > Revert "Bug 36574: Canceled/invalid ISBN not indexed by ES for MARC 21" > > This reverts commit 019e80dbbeaccfae732c59c5590da6e5a29f329b. Janusz, sorry for canceling the commit. My mistake while trying to sign the patch.
Created attachment 164799 [details] [review] Bug 36574: Canceled/invalid ISBN not indexed by ES for MARC 21 For MARC 21, canceled/invalid ISBNs (subfield 020 $z) are not being indexed in Elasticsearch (search fields identifier-standard and isbn), but it is for UNIMARC (subfield 010 $z). As a result, a user searching for such an ISBN (e.g. with wrong checksum--and therefor put in 020 $z) will not find the record in the catalogue. Test plan ========= 0. Have a test installation with Elasticsearch. 1. In ktd with its test data, make a biblio search for a cancelled ISBN e.g. 9780007269854. You will get no results. 2. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 3. Repeat the test. You should get "The ice princess / Camilla Läckberg". Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 164807 [details] [review] Bug 36574: Canceled/invalid ISBN not indexed by ES for MARC 21 For MARC 21, canceled/invalid ISBNs (subfield 020 $z) are not being indexed in Elasticsearch (search fields identifier-standard and isbn), but it is for UNIMARC (subfield 010 $z). As a result, a user searching for such an ISBN (e.g. with wrong checksum--and therefor put in 020 $z) will not find the record in the catalogue. A new isbn-all Elasticsearch search field 'isbn-all' has been created with 020az (MARC 21, and 010az for UNIMARC), 010z has been removed from isbn search field for UNIMARC, and 020z has been added to identifier-standard search field. Test plan ========= 0. Have a test installation with Elasticsearch. 1. In ktd with its test data, make a biblio search for a cancelled ISBN e.g. 9780007269854. You will get no results. 2. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 3. Repeat the test. You should get "The ice princess / Camilla Läckberg". Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
*** Bug 36726 has been marked as a duplicate of this bug. ***
Created attachment 165956 [details] [review] Bug 36574: Canceled/invalid ISBN not indexed by ES for MARC 21 For MARC 21, canceled/invalid ISBNs (subfield 020 $z) are not being indexed in Elasticsearch (search fields identifier-standard and isbn), but it is for UNIMARC (subfield 010 $z). As a result, a user searching for such an ISBN (e.g. with wrong checksum--and therefor put in 020 $z) will not find the record in the catalogue. A new isbn-all Elasticsearch search field 'isbn-all' has been created with 020az (MARC 21, and 010az for UNIMARC), 010z has been removed from isbn search field for UNIMARC, and 020z has been added to identifier-standard search field. Test plan ========= 0. Have a test installation with Elasticsearch. 1. In ktd with its test data, make a biblio search for a cancelled ISBN e.g. 9780007269854. You will get no results. 2. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 3. Repeat the test. You should get "The ice princess / Camilla Läckberg". Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Backported to 23.05.x for upcoming 23.05.12