Bug 36615 - Terminology: use 'on hold' instead of 'reserved' in OPAC self checkout
Summary: Terminology: use 'on hold' instead of 'reserved' in OPAC self checkout
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Caroline Cyr La Rose
QA Contact: Testopia
URL:
Keywords:
Depends on: 30979
Blocks:
  Show dependency treegraph
 
Reported: 2024-04-16 21:14 UTC by Caroline Cyr La Rose
Modified: 2024-04-29 07:44 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00


Attachments
Bug 36615: Terminology: use 'on hold' instead of 'reserved' in OPAC self checkout (1.72 KB, patch)
2024-04-16 21:22 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 36615: Terminology: use 'on hold' instead of 'reserved' in OPAC self checkout (1.78 KB, patch)
2024-04-17 12:00 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 36615: Terminology: use 'on hold' instead of 'reserved' in OPAC self checkout (1.84 KB, patch)
2024-04-19 18:25 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-04-16 21:14:28 UTC
In the new OPAC self checkout feature (from bug 30979), when a patron tries to check out an item that is on hold for another patron, the message says

This item appears to be reserved for another patron, please return it to the desk.

'reserved' in this case should be 'on hold' https://wiki.koha-community.org/wiki/Terminology#R

To recreate:
1. Place a hold for a patron
2. Enable OpacTrustedCheckout
3. Log into the OPAC as another patron
4. Click Self checkout at the top of the page
5. Paste the item's barcode in the text input
6. Click 'Submit'
Comment 1 Caroline Cyr La Rose 2024-04-16 21:15:20 UTC
I would also add a period at the end of the sentence.
Comment 2 Caroline Cyr La Rose 2024-04-16 21:22:20 UTC
Created attachment 164963 [details] [review]
Bug 36615: Terminology: use 'on hold' instead of 'reserved' in OPAC self checkout

This patch changes the term 'reserved' to 'on hold' in the OPAC self
checkout feature.

To test:
1. Apply patch
2. Place a hold for a patron
3. Enable OpacTrustedCheckout
4. Log into the OPAC as another patron
5. Click Self checkout at the top of the page
6. Paste the item's barcode in the text input
7. Click 'Submit'
8. Make sure the warning sentence is correct and there are no spelling
   errors
Comment 3 Caroline Cyr La Rose 2024-04-16 21:23:15 UTC
I did not add the period at the end as none of the messages had one. I can do another patch to add the periods to all the messages, if necessary.
Comment 4 Owen Leonard 2024-04-17 12:00:01 UTC
Created attachment 164999 [details] [review]
Bug 36615: Terminology: use 'on hold' instead of 'reserved' in OPAC self checkout

This patch changes the term 'reserved' to 'on hold' in the OPAC self
checkout feature.

To test:
1. Apply patch
2. Place a hold for a patron
3. Enable OpacTrustedCheckout
4. Log into the OPAC as another patron
5. Click Self checkout at the top of the page
6. Paste the item's barcode in the text input
7. Click 'Submit'
8. Make sure the warning sentence is correct and there are no spelling
   errors

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Emily Lamancusa 2024-04-19 18:25:50 UTC
Created attachment 165226 [details] [review]
Bug 36615: Terminology: use 'on hold' instead of 'reserved' in OPAC self checkout

This patch changes the term 'reserved' to 'on hold' in the OPAC self
checkout feature.

To test:
1. Apply patch
2. Place a hold for a patron
3. Enable OpacTrustedCheckout
4. Log into the OPAC as another patron
5. Click Self checkout at the top of the page
6. Paste the item's barcode in the text input
7. Click 'Submit'
8. Make sure the warning sentence is correct and there are no spelling
   errors

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 6 Emily Lamancusa 2024-04-19 18:26:12 UTC
Nice catch, thanks Caroline! Passing QA
Comment 7 Katrin Fischer 2024-04-29 07:44:11 UTC
Pushed for 24.05!

Well done everyone, thank you!