Bug 36652 - Cannot copy notice from one library to another
Summary: Cannot copy notice from one library to another
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-19 15:38 UTC by Lucas Gass (lukeg)
Modified: 2024-05-28 20:19 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06
Circulation function:

Attachments
Bug 36652: Pass copy_form template variable (1006 bytes, patch)
2024-04-19 17:23 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 36652: Pass copy_form template variable (1.03 KB, patch)
2024-04-19 19:51 UTC, Roman Dolny 		Details | Diff | Splinter Review
Bug 36652: Pass copy_form template variable (1.11 KB, patch)
2024-04-23 09:45 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-04-19 15:38:12 UTC 
To recreate:

1. Go to Tools > Notices and slips
2. Pick any notice and try to copy it to another library using the 'Copy notice' column.
3. You are redirected to a blank screen and if you go back to the Notices and slips page the notice has not been copied.
Comment 1 Lucas Gass (lukeg) 2024-04-19 17:23:58 UTC 
Created attachment 165222 [details] [review]
Bug 36652: Pass copy_form template variable

To test:

1. Go to Tools > Notices and slips
2. Pick any notice and try to copy it to another library using the 'Copy notice' column.
3. You are redirected to a blank screen and if you go back to the Notices and slips page the notice has not been copied.
4. APPLY PATCH
5. Try steps 1 - 3 again, but this time you should be correctly directed.
Comment 2 Roman Dolny 2024-04-19 19:51:37 UTC 
Created attachment 165230 [details] [review]
Bug 36652: Pass copy_form template variable

To test:

1. Go to Tools > Notices and slips
2. Pick any notice and try to copy it to another library using the 'Copy notice' column.
3. You are redirected to a blank screen and if you go back to the Notices and slips page the notice has not been copied.
4. APPLY PATCH
5. Try steps 1 - 3 again, but this time you should be correctly directed.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Jonathan Druart 2024-04-23 09:45:12 UTC 
I didn't find out the cause of the regression.
Comment 4 Jonathan Druart 2024-04-23 09:45:24 UTC 
Created attachment 165362 [details] [review]
Bug 36652: Pass copy_form template variable

To test:

1. Go to Tools > Notices and slips
2. Pick any notice and try to copy it to another library using the 'Copy notice' column.
3. You are redirected to a blank screen and if you go back to the Notices and slips page the notice has not been copied.
4. APPLY PATCH
5. Try steps 1 - 3 again, but this time you should be correctly directed.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Katrin Fischer 2024-04-26 06:54:01 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-23 15:02:26 UTC 
Pushed to 23.11.x for 23.11.06
Comment 7 Lucas Gass (lukeg) 2024-05-28 20:19:33 UTC 
Not needed in 23.05.x