You can access the detail information about a cataloguing concern either from the cataloguing module (cat) or the bibliographic record (bib) bib: The assignee doesn't display in the upper right corner cat: The assignee DOES display in the upper right corner For both: If no update text was written, we miss a space in the info on the right side: Nicole SchneiderPrivate
Created attachment 166241 [details] [review] Bug 36757: Sync concerns tables This patch re-syncs the two catalog concerns display tables markup. We add the 'Title' field into the catalog/detail version of the table and split the columns settings so you can control the table distinctly from the cataloguing module version so we can hide 'title' by default in the details display tab. This results in the table matching the display from the cataloguing module page, i.e. the assignee and status detail displays.
I'm not seeing any changes (I even reset_all).
Hmm, that's interesting.. it's all working for me here. I set an assignee and that displays in the table.. I create some status and resolved AV's and use them, and those appear in the table.
Oh.. the Modal is also displayed different.. let me look at that now
Created attachment 166259 [details] [review] Bug 36757: Sync concerns tables This patch re-syncs the two catalog concerns display tables markup. We add the 'Title' field into the catalog/detail version of the table and split the columns settings so you can control the table distinctly from the cataloguing module version so we can hide 'title' by default in the details display tab. This results in the table matching the display from the cataloguing module page, i.e. the assignee and status detail displays.
Good catch David, I've corrected that now too.. I'd missed passing the assignee via the table action button.. it's now there too.
Created attachment 166295 [details] [review] Bug 36757: Sync concerns tables This patch re-syncs the two catalog concerns display tables markup. We add the 'Title' field into the catalog/detail version of the table and split the columns settings so you can control the table distinctly from the cataloguing module version so we can hide 'title' by default in the details display tab. This results in the table matching the display from the cataloguing module page, i.e. the assignee and status detail displays. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
(In reply to Katrin Fischer from comment #0) > For both: > If no update text was written, we miss a space in the info on the right side: > Nicole SchneiderPrivate I confirmed that this patch makes the form match up when accessing it via a bib and via the concerns tool. It did not correct the spacing issue Katrin mentioned, and I didn't immediately see how to do so.
The spacing issues predate these patches and followups. I'd like to try to resolve those in a distinct bug as I've been round in circles a few times with that already and don't think doing so in this bug would be beneficial at this time
(In reply to Martin Renvoize from comment #9) > The spacing issues predate these patches and followups. I'd like to try to > resolve those in a distinct bug as I've been round in circles a few times > with that already and don't think doing so in this bug would be beneficial > at this time Filed BZ 36807 for that, agreed it's not critical to this patch.
Created attachment 166361 [details] [review] Bug 36757: Sync concerns tables This patch re-syncs the two catalog concerns display tables markup. We add the 'Title' field into the catalog/detail version of the table and split the columns settings so you can control the table distinctly from the cataloguing module version so we can hide 'title' by default in the details display tab. This results in the table matching the display from the cataloguing module page, i.e. the assignee and status detail displays. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: David Nind <david@davidnind.com>
Adding my sign off, in case that helps with QA.
Hm, I will push this as is, but I still see some differences on the detail page itself: "Details" button in last column: * Shows assignee in top right corner * Shows the "update" button after concern was resolved "speaking bubble icon" in details column: * Doesn't show assignee in top right corner * Shows the "update" and the "resolve" button after concern was resolved I'll still push this as is, but will set additional_work_needed. Can you please check? I ran yarn build and reset_all.
Pushed for 24.05! Well done everyone, thank you!
Created attachment 166453 [details] [review] Bug 36757: (QA follow-up) Fix for action on different triggers This patch updates the 'title' and 'comment count' links to action the same ticket detail/update modal as the 'details' button. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 166455 [details] [review] Bug 36757: (QA follow-up) Fix for action on different triggers This patch updates the 'title' and 'comment count' links to action the same ticket detail/update modal as the 'details' button. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Paul Derscheid <paulderscheid@gmail.com>
I am sorry, but with the follow-up the modal no longer opens when I click on the number of "changes". Can you please double check? I tried a reset_all, restart_all, private browser window...
Created attachment 166548 [details] [review] Bug 36757: (QA follow-up) Fix for action on different triggers This patch updates the 'title' and 'comment count' links to action the same ticket detail/update modal as the 'details' button. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Paul Derscheid <paulderscheid@gmail.com>
Doh.. I missed a class on that page.. the sooner I get bug 36800 done the better
Depends on Bug 35657 not in 23.11.x