Sub delete_preference does not change to lowercase like the other subs do. Fix coming.
Created attachment 166222 [details] [review] Bug 36793: Unit test This only applies to 'local' preferences. Test plan: Run sysprefs.t with/without second patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 166223 [details] [review] Bug 36793: Fix case of $var in Context->delete_preference This only applies to 'local' preferences. Test plan (first without this patch): Add a local pref. Delete it. Ask value on commandline with: * perl -MC4::Context -e"print C4::Context->preference('YOUR_PREF')" * Did you replace YOUR_PREF :) Now repeat with this patch. And verify fix (no value now). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Trivial: self SO
Created attachment 166753 [details] [review] Bug 36793: Unit test This only applies to 'local' preferences. Test plan: Run sysprefs.t with/without second patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 166754 [details] [review] Bug 36793: Fix case of $var in Context->delete_preference This only applies to 'local' preferences. Test plan (first without this patch): Add a local pref. Delete it. Ask value on commandline with: * perl -MC4::Context -e"print C4::Context->preference('YOUR_PREF')" * Did you replace YOUR_PREF :) Now repeat with this patch. And verify fix (no value now). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Backported to 23.05.x for upcoming 23.05.12