Spurious warning about undefined variable in logfiles.
Created attachment 166803 [details] [review] Bug 36878: Silence spurious warning in C4::ILSDI Test plan: Review patch and verify that: * the only effect is that no warning will be emitted in the event the variable $status is undefined, and * the variable $status being undefined is normal and harmless.
Created attachment 167561 [details] [review] Bug 36878: Silence spurious warning in C4::ILSDI Test plan: Review patch and verify that: * the only effect is that no warning will be emitted in the event the variable $status is undefined, and * the variable $status being undefined is normal and harmless. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
In what case is status expected to be undefined? It is the first return variable from checkpw which should be 1,0,-1 according to the code
The warnings in the logfile makes it apparent that $status occasionally is undefined. checkpw is a messy subroutine, but two apparent cases where $status is undefined is $patron->account_locked and $stored_hash eq '!'.