36909 – Eliminate duplicate ID in cookie consent markup

Bug 36909 - Eliminate duplicate ID in cookie consent markup

Summary: Eliminate duplicate ID in cookie consent markup

Status:	Pushed to stable

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Templates (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low trivial
Assignee:	Owen Leonard
QA Contact:	Testopia

URL:
Keywords:

Depends on:	27378
Blocks:
	Show dependency tree / graph

Reported:	2024-05-21 14:46 UTC by Owen Leonard
Modified:	2024-07-22 09:57 UTC (History)
CC List:	3 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:	This fixes HTML validation warnings about duplicate IDs in the cookie consent markup for the OPAC and staff interface.
Version(s) released in:	24.11.00,24.05.02
Circulation function:

Attachments
Bug 36909: Eliminate duplicate ID in cookie consent markup (5.41 KB, patch) 2024-05-21 14:54 UTC, Owen Leonard	Details \| Diff \| Splinter Review
Bug 36909: Eliminate duplicate ID in cookie consent markup (5.46 KB, patch) 2024-05-23 05:42 UTC, David Nind	Details \| Diff \| Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Owen Leonard 2024-05-21 14:46:41 UTC

The HTML validator complains about duplicate IDs in the cookie consent markup: One div#consentButtons in the header, one in the footer. These can be updated to be classes instead.

Comment 1 Owen Leonard 2024-05-21 14:54:48 UTC Comment hidden (obsolete)

Created attachment 166979 [details] [review]
Bug 36909: Eliminate duplicate ID in cookie consent markup

This patch changes markup and CSS in the OPAC and staff client to
eliminate HTML validator warnings about duplicate ids.

To test, apply the patch and rebuild all CSS (Bug 36909: Eliminate
duplicate ID in cookie consent markup).

- If necessary, set the "CookieConsent" system preference to "Require."
- Open the OPAC in a new private window (to prevent previous consents
  from hiding the consent messages).
- You should see a cookie consent bar across the bottom of the page. It
  should look correct, and its contents should reflow well at various
  browser widths.
- Click "Accept all cookies."
- In the header you should now see a "Your cookies" link.
- Click it and confirm that the contents of the modal look correct and
  reflow well at various browser widths.

- Perform the same tests in the staff interface.

Comment 2 David Nind 2024-05-23 05:42:18 UTC

Created attachment 167061 [details] [review]
Bug 36909: Eliminate duplicate ID in cookie consent markup

This patch changes markup and CSS in the OPAC and staff client to
eliminate HTML validator warnings about duplicate ids.

To test, apply the patch and rebuild all CSS (Bug 36909: Eliminate
duplicate ID in cookie consent markup).

- If necessary, set the "CookieConsent" system preference to "Require."
- Open the OPAC in a new private window (to prevent previous consents
  from hiding the consent messages).
- You should see a cookie consent bar across the bottom of the page. It
  should look correct, and its contents should reflow well at various
  browser widths.
- Click "Accept all cookies."
- In the header you should now see a "Your cookies" link.
- Click it and confirm that the contents of the modal look correct and
  reflow well at various browser widths.

- Perform the same tests in the staff interface.

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Katrin Fischer 2024-06-27 13:33:00 UTC

Picked from QA queue for main.

Comment 4 Katrin Fischer 2024-06-27 15:26:45 UTC

Pushed for 24.11!

Well done everyone, thank you!

Comment 5 Lucas Gass (lukeg) 2024-07-19 15:36:57 UTC

Backported to 24.05.x for upcoming 24.05.02

Comment 6 Fridolin Somers 2024-07-22 09:57:29 UTC

Does not apply on 23.11.x
Maybe some other dependancy