At least on the KBART import feature, if the file *extension* is not one of '.tsv' or '.csv', the displayed message is: ``` The file must be in .tsv or .csv format, please convert your file and try again. ``` I would write something like this instead: ``` The file extension must be either .tsv or .csv, depending on the file format. Other extensions are not accepted. ```
We will "fix" this and remove the note with Bug 36831 - Add support for .txt files to the KBART import tool (I filed a similar report yesterday)
Created attachment 167022 [details] [review] Bug 36921: Fix error description on KBART file import Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I had a go at testing, however I'm not seeing the error message before or after the patch is applied. I used the test file from bug 36831 Something pops up and then disappears very quickly, and the file is not loaded. No titles are imported (as expected).
I wonder if this error in the console is related: Uncaught (in promise) TypeError: can't access property "invalid_columns", success.warnings is undefined addDocument webpack://koha/./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesKBARTImport.vue?./node_modules/vue-loader/dist/index.js??ruleSet[1].rules[5].use[0]:86 erm_24.0600000.js line 2026 > eval:86:25
No message, but only a popup appears very briefly, no time to read it. As expected, the file is not loaded.