Bug 36937 - api/v1/password_validation.t generates warnings
Summary: api/v1/password_validation.t generates warnings
Status: Pushed to oldoldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Matt Blenkinsop
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on: 35204
Blocks: 25515
  Show dependency tree / graph
 
Reported: 2024-05-23 07:42 UTC by Jonathan Druart
Modified: 2024-09-12 02:06 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the cause of a warning for the t/db_dependent/api/v1/password_validation.t tests (warning fixed: Use of uninitialized value $status in numeric eq (==)).
Version(s) released in:
24.11.00,24.05.02,23.11.07,23.05.15
Circulation function:

Attachments
Bug 36937: Remove warning from unit tests (1.29 KB, patch)
2024-05-23 09:25 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Bug 36937: Remove warning from unit tests (1.35 KB, patch)
2024-05-23 09:38 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 36937: Remove warning from unit tests (1.39 KB, patch)
2024-05-25 20:12 UTC, David Nind 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-05-23 07:42:59 UTC 
t/db_dependent/api/v1/password_validation.t .. Use of uninitialized value $status in numeric eq (==) at /kohadevbox/koha/Koha/REST/V1/Auth/Password.pm line 76.
Comment 1 Matt Blenkinsop 2024-05-23 09:25:04 UTC 
Created attachment 167082 [details] [review]
Bug 36937: Remove warning from unit tests

This patch fixes a warning in the unit tests

Test plan:
1) prove t/db_dependent/api/v1/password_validation.t
2) There will be a warning in the output - 'Use of uninitialized value $status in numeric eq (==)'
3) Apply patch
4) Re-run the test
5) The warning will disappear
Comment 2 Jonathan Druart 2024-05-23 09:38:49 UTC 
Created attachment 167083 [details] [review]
Bug 36937: Remove warning from unit tests

This patch fixes a warning in the unit tests

Test plan:
1) prove t/db_dependent/api/v1/password_validation.t
2) There will be a warning in the output - 'Use of uninitialized value $status in numeric eq (==)'
3) Apply patch
4) Re-run the test
5) The warning will disappear

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 David Nind 2024-05-25 20:12:26 UTC 
Created attachment 167181 [details] [review]
Bug 36937: Remove warning from unit tests

This patch fixes a warning in the unit tests

Test plan:
1) prove t/db_dependent/api/v1/password_validation.t
2) There will be a warning in the output - 'Use of uninitialized value $status in numeric eq (==)'
3) Apply patch
4) Re-run the test
5) The warning will disappear

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2024-05-25 20:13:16 UTC 
I've added my sign off as well (followed the test plan).

Maybe Jonathan can the do the QA.
Comment 5 Martin Renvoize (ashimema) 2024-06-13 13:33:07 UTC 
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 6 Lucas Gass (lukeg) 2024-07-18 17:42:56 UTC 
Backported to 24.05.x for upcoming 24.05.02
Comment 7 Fridolin Somers 2024-07-19 07:34:14 UTC 
Pushed to 23.11.x for 23.11.07
Comment 8 Wainui Witika-Park 2024-09-12 02:06:23 UTC 
Pushed to 23.05.x for 23.05.15