Bug 36940 - Resolve two Auth warnings when AutoLocation is enabled having a branch without branchip
Summary: Resolve two Auth warnings when AutoLocation is enabled having a branch withou...
Status: Pushed to oldoldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Marcel de Rooy
QA Contact: Nick Clemens (kidclamp)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-23 08:47 UTC by Marcel de Rooy
Modified: 2024-09-12 02:39 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes two warnings in the log files when the AutoLocation system preference is enabled and there is a library without an IP address. Warning messages: [WARN] Use of uninitialized value $domain in substitution (s///) at /usr/share/koha/C4/Auth.pm line 1223. [WARN] Use of uninitialized value $domain in regexp compilation at /usr/share/koha/C4/Auth.pm line 1224.
Version(s) released in:
24.11.00,24.05.02,23.11.07,23.05.15
Circulation function:

Attachments
Bug 36940: Resolve two warnings on undefined branchip (1.53 KB, patch)
2024-05-23 08:51 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 36940: Resolve two warnings on undefined branchip (1.63 KB, patch)
2024-05-30 13:36 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2024-05-23 08:47:23 UTC 
From 22.11 but still on master too:

[2024/05/23 10:37:11] [WARN] Use of uninitialized value $domain in substitution (s///) at /usr/share/koha/C4/Auth.pm line 1199.
[2024/05/23 10:37:11] [WARN] Use of uninitialized value $domain in regexp compilation at /usr/share/koha/C4/Auth.pm line 1200.
Comment 1 Marcel de Rooy 2024-05-23 08:50:57 UTC 
These are the master ones:

[2024/05/23 08:50:30] [WARN] Use of uninitialized value $domain in substitution (s///) at /usr/share/koha/C4/Auth.pm line 1222.
[2024/05/23 08:50:30] [WARN] Use of uninitialized value $domain in substitution (s///) at /usr/share/koha/C4/Auth.pm line 1223.
[2024/05/23 08:50:30] [WARN] Use of uninitialized value $domain in regexp compilation at /usr/share/koha/C4/Auth.pm line 1224.
Comment 2 Marcel de Rooy 2024-05-23 08:51:59 UTC 
Created attachment 167079 [details] [review]
Bug 36940: Resolve two warnings on undefined branchip

If you enabled AutoLocation and have a branch without ip, this
triggers warnings.

Test plan:
Check logs in this situation with/without this patch by logging out
and in again on staff.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2024-05-23 09:21:12 UTC 
Noticed that turning on AutoLocation will make Auth.t fail. But thats outside the scope of this trivial report.
Comment 4 Marcel de Rooy 2024-05-23 09:22:32 UTC 
Trivial: Self SO
Comment 5 Nick Clemens (kidclamp) 2024-05-30 13:36:52 UTC 
Created attachment 167274 [details] [review]
Bug 36940: Resolve two warnings on undefined branchip

If you enabled AutoLocation and have a branch without ip, this
triggers warnings.

Test plan:
Check logs in this situation with/without this patch by logging out
and in again on staff.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Martin Renvoize (ashimema) 2024-06-13 13:33:10 UTC 
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 7 Lucas Gass (lukeg) 2024-07-18 17:49:04 UTC 
Backported to 24.05.x for upcoming 24.05.02
Comment 8 Fridolin Somers 2024-07-19 07:42:07 UTC 
Pushed to 23.11.x for 23.11.07
Comment 9 Wainui Witika-Park 2024-09-12 02:39:39 UTC 
Backported to 23.05.x for 23.05.15