Currently, we appear to still list all libraries in the dropdown when the `StaffLoginRestrictBranchByIP` preference is enabled.. this is unclear to the end user. We should be able to distinguish the IP range before loading the login page and thus only display valid options in the list (or at least display the invalid options as disabled) Question however.. how should this work for a librarian with increased privileges.. perhaps we should hint they're unavailable but not actually disable their selection for this use case?
Created attachment 167108 [details] [review] Bug 36941: Limit login branch list when IP restriction enabled This patch adds a new 'ip_limit' option to Koha::Template:Plugin::Branches To test: 1 - Set some branches in the system to have random IPs 2 - Set one branch to have your IP To find the IP in KTD I: Enabled ILS-DI Set ILS-DI:AuthorizedIPs to 1.1.1.1 Visit: http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=248&id_type=biblio And note the unauthorized IP listed 3 - Log out, confirm all branches are listed 4 - Log in, enable StaffLoginRestrictLibraryByIP 5 - Log out, confirm branches with IPs are removed 6 - Confirm branch matching your IP is listed 7 - Choose any of the branches and login 8 - Confirm login works
(In reply to Martin Renvoize from comment #0) > Question however.. how should this work for a librarian with increased > privileges.. perhaps we should hint they're unavailable but not actually > disable their selection for this use case? Current code also applies to superlibrarians - they can switch to any branch once logged in, but this forces them to use a valid branch at login As I stated elsewhere, I think the intention here was to prevent users from accidentally logging in to the wrong branch if they are not at their usual location. If you think it needs adjustment I think that's a new bug
Created attachment 167201 [details] [review] Bug 36941: Limit login branch list when IP restriction enabled This patch adds a new 'ip_limit' option to Koha::Template:Plugin::Branches To test: 1 - Set some branches in the system to have random IPs 2 - Set one branch to have your IP To find the IP in KTD I: Enabled ILS-DI Set ILS-DI:AuthorizedIPs to 1.1.1.1 Visit: http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=248&id_type=biblio And note the unauthorized IP listed 3 - Log out, confirm all branches are listed 4 - Log in, enable StaffLoginRestrictLibraryByIP 5 - Log out, confirm branches with IPs are removed 6 - Confirm branch matching your IP is listed 7 - Choose any of the branches and login 8 - Confirm login works Signed-off-by: David Nind <david@davidnind.com>
Created attachment 168196 [details] [review] Bug 36941: Limit login branch list when IP restriction enabled This patch adds a new 'ip_limit' option to Koha::Template:Plugin::Branches To test: 1 - Set some branches in the system to have random IPs 2 - Set one branch to have your IP To find the IP in KTD I: Enabled ILS-DI Set ILS-DI:AuthorizedIPs to 1.1.1.1 Visit: http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=248&id_type=biblio And note the unauthorized IP listed 3 - Log out, confirm all branches are listed 4 - Log in, enable StaffLoginRestrictLibraryByIP 5 - Log out, confirm branches with IPs are removed 6 - Confirm branch matching your IP is listed 7 - Choose any of the branches and login 8 - Confirm login works Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks Nick, All works as described, no regressions.. Passing QA
Pushed for 24.11! Well done everyone, thank you!