Currently we warn an error message if there is an error parsing a KBART file. We should change this to use an exception
Created attachment 168439 [details] [review] Bug 36942: Use an exception for a failed KBART file parse Test plan: 1) prove t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t
Note: A dependent bug no longer applies (and is also Failed QA).
(same as David, so I put it in "DNA" for review)
Getting a sha1/fake ancestor error. git bz apply 36942 Bug 36942 Depends on bug 36831 (Signed Off) Follow? [(y)es, (n)o] y Bug 36831 - Add support for .txt files to the KBART import tool 179679 - Bug 36831: Add a method to determine the file delimiter 179680 - Bug 36831: Move logic from the background job to the Title object class 179681 - Bug 36831: Add unit test 179682 - Bug 36831: Allow for multiple file types Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36831: Add a method to determine the file delimiter Applying: Bug 36831: Move logic from the background job to the Title object class Applying: Bug 36831: Add unit test Applying: Bug 36831: Allow for multiple file types Bug 36942 - Throw an exception if a KBART file can't be read 168439 - Bug 36942: Use an exception for a failed KBART file parse Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36942: Use an exception for a failed KBART file parse error: sha1 information is lacking or useless (Koha/ERM/EHoldings/Title.pm). error: could not build fake ancestor Patch failed at 0001 Bug 36942: Use an exception for a failed KBART file parse
Created attachment 182608 [details] [review] Bug 36942: Use an exception for a failed KBART file parse Test plan: 1) prove t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t
Created attachment 182610 [details] [review] Bug 36942: Use an exception for a failed KBART file parse Test plan: 1) prove t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t Signed-off-by: David Nind <david@davidnind.com>