Bug 36945 - Fix several missed instance of breadcrumb WRAPPER use
Summary: Fix several missed instance of breadcrumb WRAPPER use
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency tree / graph
 
Reported: 2024-05-23 12:29 UTC by Owen Leonard
Modified: 2024-11-18 12:26 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement makes structural changes to the way the breadcrumb menu is generated on several pages for more consistency and ease of upgrade to new Bootstrap versions.
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 36945: Fix several missed instance of breadcrumb WRAPPER use (8.87 KB, patch)
2024-05-23 14:36 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 36945: Fix several missed instance of breadcrumb WRAPPER use (8.92 KB, patch)
2024-05-23 21:11 UTC, David Nind 		Details | Diff | Splinter Review
Bug 36945: Fix several missed instance of breadcrumb WRAPPER use (8.05 KB, patch)
2024-08-23 17:49 UTC, Owen Leonard 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-05-23 12:29:03 UTC 
Several templates in the staff interface still need to have the breadcrumb WRAPPER update:

- cataloguing/concerns.tt
- offline_circ/enqueue_koc.tt
- offline_circ/list.tt
- offline_circ/process_koc.tt
- reports/cash_register_stats.tt
Comment 1 Owen Leonard 2024-05-23 14:36:53 UTC 
Created attachment 167115 [details] [review]
Bug 36945: Fix several missed instance of breadcrumb WRAPPER use

This patch corrects some templates which never got the breadcrumb
WRAPPER update. Some breadcrumbs and page titles have been updated to be
more consistent with page headings.

To test, apply the patch and enable the "CatalogConcerns" system
preference if necessary. Check the following pages to confirm that the
breadcrumbs menu looks correct and that breadcrumbs are consistent with
page titles and page headings.

- Circulation -> Upload offline circulation file (.koc)
  - Upload file -> Add to offline circulation queue
  - View pending offline circulation actions
- Cataloging -> Cataloging concerns
- Reports -> Cash register stats

Sponsored-By: Athens County Public Libraries
Comment 2 David Nind 2024-05-23 21:11:59 UTC 
Created attachment 167138 [details] [review]
Bug 36945: Fix several missed instance of breadcrumb WRAPPER use

This patch corrects some templates which never got the breadcrumb
WRAPPER update. Some breadcrumbs and page titles have been updated to be
more consistent with page headings.

To test, apply the patch and enable the "CatalogConcerns" system
preference if necessary. Check the following pages to confirm that the
breadcrumbs menu looks correct and that breadcrumbs are consistent with
page titles and page headings.

- Circulation -> Upload offline circulation file (.koc)
  - Upload file -> Add to offline circulation queue
  - View pending offline circulation actions
- Cataloging -> Cataloging concerns
- Reports -> Cash register stats

Sponsored-By: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Owen Leonard 2024-08-23 17:49:09 UTC 
Created attachment 170657 [details] [review]
Bug 36945: Fix several missed instance of breadcrumb WRAPPER use

This patch corrects some templates which never got the breadcrumb
WRAPPER update. Some breadcrumbs and page titles have been updated to be
more consistent with page headings.

To test, apply the patch and enable the "CatalogConcerns" system
preference if necessary. Check the following pages to confirm that the
breadcrumbs menu looks correct and that breadcrumbs are consistent with
page titles and page headings.

- Circulation -> Upload offline circulation file (.koc)
  - Upload file -> Add to offline circulation queue
  - View pending offline circulation actions
- Cataloging -> Cataloging concerns
- Reports -> Cash register stats

Sponsored-By: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2024-09-02 08:54:14 UTC 
QA'd by RM.
Comment 5 Katrin Fischer 2024-09-02 10:21:15 UTC 
Pushed for 24.11!

Well done everyone, thank you!