In the POS module, the 'Issue refund' modal on registers.pl mistakenly carries forward the amount paid to subsequent modals. Steps to reproduce: -Have the Point of Sale module enabled, a cash register defined and multiple debit types defined -Make multiple sales -View the transaction history for your sales on register.pl -Click on the 'Issue refund' button for one of the sales -Notice that the 'amount paid' displays the amount of the sale -Realize that you selected the wrong transaction for the refund -Find the actual transaction you want to refund and click on the 'Issue refund' button -Notice that the amount listed in the 'amount paid' area is the amount from the first refund you attempted to make, not the amount for the transaction now being handled In the attached screenshots one shows a payment of 3.80. That turned out to be the wrong transaction. Staff then located the correct transaction to be refunded. The amount shows 3.80 (carried over from the previous transaction that was clicked on) but the amount of the original payment was actually 7.40. Not only is the amount of 3.80 incorrect but it is especially confusing since it looks as if you would be refunding more than the original payment.
Created attachment 167293 [details] Amount paid in 'Issue refund modal
Created attachment 167294 [details] Incorrect amount paid in 'Issue refund modal carried over from previous transaction
Created attachment 169589 [details] [review] Bug 36998: Correctly update the 'Amount paid' displayed on the issue refund modal To test: 1) Enable the 'EnablePointOfSale' sys pref (also requires the 'UseCashRegisters' pref) 2) In the POS module, configure a cash register and also configure some items for purchase with different costs 3) Make multiple sales 4) View the transactions table by clicking the 'Cash summary for ...' tab and then clicking on your cash register's name. 5) Click on the 'Issue refund' button for one of the sales, this should have the correct 'Amount paid' 6) Close the modal and click issue refund on your other item. 7) Note the 'Amount paid' is incorrect and lists the value from the previous item 8) Apply patch 9) Now when clicking issue refund, it displays the correct 'Amount paid'
Created attachment 169596 [details] [review] Bug 36998: Correctly update the 'Amount paid' displayed on the issue refund modal To test: 1) Enable the 'EnablePointOfSale' sys pref (also requires the 'UseCashRegisters' pref) 2) In the POS module, configure a cash register and also configure some items for purchase with different costs 3) Make multiple sales 4) View the transactions table by clicking the 'Cash summary for ...' tab and then clicking on your cash register's name. 5) Click on the 'Issue refund' button for one of the sales, this should have the correct 'Amount paid' 6) Close the modal and click issue refund on your other item. 7) Note the 'Amount paid' is incorrect and lists the value from the previous item 8) Apply patch 9) Now when clicking issue refund, it displays the correct 'Amount paid' Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Created attachment 169740 [details] [review] Bug 36998: Correctly update the 'Amount paid' displayed on the issue refund modal To test: 1) Enable the 'EnablePointOfSale' sys pref (also requires the 'UseCashRegisters' pref) 2) In the POS module, configure a cash register and also configure some items for purchase with different costs 3) Make multiple sales 4) View the transactions table by clicking the 'Cash summary for ...' tab and then clicking on your cash register's name. 5) Click on the 'Issue refund' button for one of the sales, this should have the correct 'Amount paid' 6) Close the modal and click issue refund on your other item. 7) Note the 'Amount paid' is incorrect and lists the value from the previous item 8) Apply patch 9) Now when clicking issue refund, it displays the correct 'Amount paid' Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant
Backported to 24.05.x for 24.05.04
Pushed to 23.11.x for 23.11.09
Not backporting to 23.05.x unless requested