Bug 36999 - 00-strict.t fails to find koha_perl_deps.pl
Summary: 00-strict.t fails to find koha_perl_deps.pl
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on: 36323
Blocks:
  Show dependency treegraph
 
Reported: 2024-05-31 07:41 UTC by Fridolin Somers
Modified: 2024-09-12 01:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the tests in t/db_dependent/00-strict.t. The tests were failing as a file (koha_perl_deps.pl) was moved and is no longer required for these tests.
Version(s) released in:
24.11.00,24.05.02,23.11.07
Circulation function:


Attachments
Bug 36999: Fix 00-strict.t fails to find koha_perl_deps.pl (1.22 KB, patch)
2024-05-31 07:47 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 36999: Fix 00-strict.t fails to find koha_perl_deps.pl (1.27 KB, patch)
2024-05-31 17:53 UTC, David Nind
Details | Diff | Splinter Review
Bug 36999: Fix 00-strict.t fails to find koha_perl_deps.pl (1.35 KB, patch)
2024-06-12 14:27 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2024-05-31 07:41:54 UTC
Since Bug 36323 moved koha_perl_deps.pl it is not needed anymore in 00-strict.t
It fails with :
koha_1       | Can't stat koha_perl_deps.pl: No such file or directory
koha_1       |  at /usr/share/perl5/Test/Strict.pm line 151.
Comment 1 Fridolin Somers 2024-05-31 07:47:14 UTC
Created attachment 167301 [details] [review]
Bug 36999: Fix 00-strict.t fails to find koha_perl_deps.pl

Since Bug 36323 moved koha_perl_deps.pl it is not needed anymore in 00-strict.t
It fails with :
koha_1       | Can't stat koha_perl_deps.pl: No such file or directory
koha_1       |  at /usr/share/perl5/Test/Strict.pm line 151.

Patch remove koha_perl_deps.pl from @dirs.
It contains misc.

Test plan :
prove t/db_dependent/00-strict.t
Comment 2 David Nind 2024-05-31 17:53:25 UTC
Created attachment 167314 [details] [review]
Bug 36999: Fix 00-strict.t fails to find koha_perl_deps.pl

Since Bug 36323 moved koha_perl_deps.pl it is not needed anymore in 00-strict.t
It fails with :
koha_1       | Can't stat koha_perl_deps.pl: No such file or directory
koha_1       |  at /usr/share/perl5/Test/Strict.pm line 151.

Patch remove koha_perl_deps.pl from @dirs.
It contains misc.

Test plan :
prove t/db_dependent/00-strict.t

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-05-31 17:54:30 UTC
Testing notes (using KTD):

1. It takes a while to run (1,157 tests!), in case you are wondering what is happening:

prove t/db_dependent/00-strict.t
t/db_dependent/00-strict.t .. ok      
All tests successful.
Files=1, Tests=1157, 105 wallclock secs ( 0.02 usr  0.00 sys + 638.52 cusr 118.27 csys = 756.81 CPU)
Result: PASS
Comment 4 Matt Blenkinsop 2024-06-12 14:27:56 UTC
Created attachment 167666 [details] [review]
Bug 36999: Fix 00-strict.t fails to find koha_perl_deps.pl

Since Bug 36323 moved koha_perl_deps.pl it is not needed anymore in 00-strict.t
It fails with :
koha_1       | Can't stat koha_perl_deps.pl: No such file or directory
koha_1       |  at /usr/share/perl5/Test/Strict.pm line 151.

Patch remove koha_perl_deps.pl from @dirs.
It contains misc.

Test plan :
prove t/db_dependent/00-strict.t

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2024-06-13 12:43:33 UTC
Strange.. I've not seen any failures on Jenkins for this.
Comment 6 Martin Renvoize (ashimema) 2024-06-13 13:33:16 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 7 Lucas Gass (lukeg) 2024-07-18 17:35:13 UTC
Backported to 24.05.x for upcoming 24.05.02
Comment 8 Fridolin Somers 2024-07-19 07:32:25 UTC
Pushed to 23.11.x for 23.11.07
Comment 9 Wainui Witika-Park 2024-09-12 01:23:41 UTC
Not backporting to 23.05.x unless requested