I would like to add the proper branchcode as an HTML class to each <li> item in the staff search results. There are three possible <ul>'s here: -onloan_items_loop_items -available_items_loop_items -other_items_loop_items Having the correct branch code here will make it much easier to write CSS/JS customization for a particular branch.
Created attachment 167317 [details] [review] Bug 37004: Add branchcode as HTML class to each grouped result in search results To test: 1. Apply patch and restart_all 2. Do a catalog search that returns results. 3. Using the browsers dev tools inscpet the page and look for the 'available_items_loop_items' class in the 'Location column'. 4. Each child <li> element should have a class that is the branchcode. 5. Make sure that branchcode is correct. 6. Change the StaffSearchResultsDisplayBranch system preference. Make sure that each branchcode is still correct. 7. Change the system preference 'noItemTypeImages' to 'Dont show'. 8. Make sure the branchcode is still correct. 9. Checkout an item that would show up in these search results. 10. Do steps 3-8 again excpet this time look for the HTML element 'onloan_items_loop_items'. 11. Put some items in transfer that would show up in these search resultss. 12. Do steps 3-8 again excpet this time look for the HTML element 'other_items_loop_items'.
Created attachment 167322 [details] [review] Bug 37004: Add branchcode as HTML class to each grouped result in search results To test: 1. Apply patch and restart_all 2. Do a catalog search that returns results. 3. Using the browsers dev tools inscpet the page and look for the 'available_items_loop_items' class in the 'Location column'. 4. Each child <li> element should have a class that is the branchcode. 5. Make sure that branchcode is correct. 6. Change the StaffSearchResultsDisplayBranch system preference. Make sure that each branchcode is still correct. 7. Change the system preference 'noItemTypeImages' to 'Dont show'. 8. Make sure the branchcode is still correct. 9. Checkout an item that would show up in these search results. 10. Do steps 3-8 again excpet this time look for the HTML element 'onloan_items_loop_items'. 11. Put some items in transfer that would show up in these search resultss. 12. Do steps 3-8 again excpet this time look for the HTML element 'other_items_loop_items'. Signed-off-by: David Nind <david@davidnind.com>
QA'd by RM
Pushed for 24.11! Well done everyone, thank you!