When one makes a GET call to holds endpoint and hold has item attached to it, item_id is handled as string not integer as it should. To reproduce: 1. Make sure you have hold waiting in your database. 1. Call endpoint api/v1/holds/?q=[{"me.status":"W"}]. 2. Note that holds item_id is displayed as item_id: "12345".
Created attachment 167370 [details] [review] Bug 37021: Change item_id type as integer in holds endpoint When one makes a GET call to holds endpoint and hold has item attached to it, item_id is handled as string not integer as it should. To reproduce: 1. Make sure you have hold waiting in your database. 2. Call endpoint api/v1/holds/?q=[{"me.status":"W"}]. => Note that holds item_id is displayed as item_id: "12345". 3. Apply this patch. 4. Call endpoint again. => item_id should now be displayed as 12345. Also prove t/db_dependent/api/v1/holds.t.
Created attachment 167430 [details] [review] Bug 37021: Change item_id type as integer in holds endpoint When one makes a GET call to holds endpoint and hold has item attached to it, item_id is handled as string not integer as it should. To reproduce: 1. Make sure you have hold waiting in your database. 2. Call endpoint api/v1/holds/?q=[{"me.status":"W"}]. => Note that holds item_id is displayed as item_id: "12345". 3. Apply this patch. 4. Call endpoint again. => item_id should now be displayed as 12345. Also prove t/db_dependent/api/v1/holds.t. Signed-off-by: Jan Kissig <jkissig@th-wildau.de>
Created attachment 167453 [details] [review] Bug 37021: Change item_id type as integer in holds endpoint When one makes a GET call to holds endpoint and hold has item attached to it, item_id is handled as string not integer as it should. To reproduce: 1. Make sure you have hold waiting in your database. 2. Call endpoint api/v1/holds/?q=[{"me.status":"W"}]. => Note that holds item_id is displayed as item_id: "12345". 3. Apply this patch. 4. Call endpoint again. => item_id should now be displayed as 12345. Also prove t/db_dependent/api/v1/holds.t. Signed-off-by: Jan Kissig <jkissig@th-wildau.de> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant
Backported to 24.05.x for upcoming 24.05.02
Pushed to 23.11.x for 23.11.07
Looks like same issue with api/v1/swagger/definitions/club_hold.yaml : https://git.koha-community.org/Koha-community/Koha/src/commit/33175fddec69ad38d8cb8a9dc590f2f7998149b0/api/v1/swagger/definitions/club_hold.yaml#L13
not backporting to 23.05.x unless requested