We need to make a modification to the cart view and tried to create a plugin that injects javascript to the cart view. It won't get applied to cgi-bin/koha/basket/basket.pl since it's template is missing it's [% INCLUDE 'intranet-bottom.inc' %] which loads the plugin subs called intranet_js to the browser. I added the code to basket.tt and now the plugin's intranet_js gets applied to the view. This issue may occur in similar popup views elsewhere in the Koha intranet too, where we have decided not to include the intranet-bottom.inc to the browser view. Should this ticket be made a generic one dealing with all similar occurences throughout Koha intranet (Z39.50 search for example)? Is there any downside for having the bottom bar in these views?
I imagine a case by case basis is all right.
It seems Z39.50 search is using [% INCLUDE 'intranet-bottom.inc' popup_window=1 %] which allows the plugin js to be loaded with the view. I'll make a patch for cart/basket view using this.
Created attachment 167429 [details] [review] Bug 37033: Plugin intranet_js won't load in Cart popup (intranet-bottom.inc missing)
Created attachment 167844 [details] [review] Bug 37033: Plugin intranet_js won't load in Cart popup (intranet-bottom.inc missing) Signed-off-by: Owen Leonard <oleonard@myacpl.org>
QA'd by RM. One line change.
Pushed for 24.11! Well done everyone, thank you!