Bug 37048 - Use template wrapper for self checkout page
Summary: Use template wrapper for self checkout page
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on: 32571
Blocks:
  Show dependency treegraph
 
Reported: 2024-06-06 16:57 UTC by Owen Leonard
Modified: 2024-11-15 20:30 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement makes structural changes to the way the self checkout page is generated for more consistency and ease of upgrade to new Bootstrap versions.
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37048: Use template wrapper for self checkout page (25.63 KB, patch)
2024-06-06 17:25 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37048: Use template wrapper for self checkout page (25.67 KB, patch)
2024-06-06 22:06 UTC, David Nind
Details | Diff | Splinter Review
Bug 37048: Use template wrapper for self checkout page (25.69 KB, patch)
2024-08-23 18:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37048: Use template wrapper for self checkout page (25.74 KB, patch)
2024-08-27 21:44 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-06-06 16:57:31 UTC
Continuing the work of Bug 32571, self checkout page should be updated to use the new WRAPPER for tabs.
Comment 1 Owen Leonard 2024-06-06 17:25:58 UTC
Created attachment 167554 [details] [review]
Bug 37048: Use template wrapper for self checkout page

This patch updates the OPAC's self checkout page template to use
WRAPPERs for the Bootstrap tabs markup.

To test, apply the patch and enable the "WebBasedSelfCheck" system
preference if necessary.

- Navigate to the self checkout page
  (http://127.0.0.1:8080/cgi-bin/koha/sco/sco-main.pl)
  - Start checking out to a patron
    - You should see three tabs, "Checkouts", "Holds", and "Charges."
      The tabs should look correct and work correctly.

Sponsored-By: Athens County Public Libraries
Comment 2 David Nind 2024-06-06 22:06:00 UTC
Created attachment 167559 [details] [review]
Bug 37048: Use template wrapper for self checkout page

This patch updates the OPAC's self checkout page template to use
WRAPPERs for the Bootstrap tabs markup.

To test, apply the patch and enable the "WebBasedSelfCheck" system
preference if necessary.

- Navigate to the self checkout page
  (http://127.0.0.1:8080/cgi-bin/koha/sco/sco-main.pl)
  - Start checking out to a patron
    - You should see three tabs, "Checkouts", "Holds", and "Charges."
      The tabs should look correct and work correctly.

Sponsored-By: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Owen Leonard 2024-08-23 18:04:09 UTC
Created attachment 170661 [details] [review]
Bug 37048: Use template wrapper for self checkout page

This patch updates the OPAC's self checkout page template to use
WRAPPERs for the Bootstrap tabs markup.

To test, apply the patch and enable the "WebBasedSelfCheck" system
preference if necessary.

- Navigate to the self checkout page
  (http://127.0.0.1:8080/cgi-bin/koha/sco/sco-main.pl)
  - Start checking out to a patron
    - You should see three tabs, "Checkouts", "Holds", and "Charges."
      The tabs should look correct and work correctly.

Sponsored-By: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Lucas Gass (lukeg) 2024-08-27 21:44:44 UTC
Created attachment 170788 [details] [review]
Bug 37048: Use template wrapper for self checkout page

This patch updates the OPAC's self checkout page template to use
WRAPPERs for the Bootstrap tabs markup.

To test, apply the patch and enable the "WebBasedSelfCheck" system
preference if necessary.

- Navigate to the self checkout page
  (http://127.0.0.1:8080/cgi-bin/koha/sco/sco-main.pl)
  - Start checking out to a patron
    - You should see three tabs, "Checkouts", "Holds", and "Charges."
      The tabs should look correct and work correctly.

Sponsored-By: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Katrin Fischer 2024-08-29 16:17:00 UTC
Pushed for 24.11!

Well done everyone, thank you!