Bug 37084 - Batch Item modification not modify items after save
Summary: Batch Item modification not modify items after save
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 24.05
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-13 21:56 UTC by George Veranis
Modified: 2024-06-14 00:37 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description George Veranis 2024-06-13 21:56:10 UTC
When trying to modify at least one or more items using batch mode functionality, then Koha is allowed to Save it but if you check the background process then the message is No Items modified. 
The problem seems to be at Koha::UI::Table::Builder::Items on the function build_table where itemnumber is missing and for that reason is not loaded as a value parameter on checkbox. I will submit the patch and the test plan soon.
Comment 1 David Nind 2024-06-14 00:37:52 UTC
I tested on main and 24.05.00 (using koha-testing-docker), and I could not replicate the issue.

This is how I tested:
1. Go to Cataloging > Batch editing > Batch item modification.
2. Add these two barcodes to the barcode list field:
   39999000000498
   39999000000559
3. Click continue.
4. All items are shown as selected.
5. Add "This is a public note" to z - Public note.
6. Click Save.
7. Result: Message saying "The job has been enqueued", with a link to view the details.
8. Click on the link "View detail of the enqueued job".
9. The details page for them job is displayed - once completed, it should be successful and display "2 item(s) modified (with 2 field(s) modified).", and the list of records modified displayed under the detailed messages.

Notes:
1. You have to wait for the job to finish, or refresh the job details page once it has finished.
2. You should get a warning if barcodes are not found.
3. I'm not sure how to check if the processes/services running background jobs are working as expected. (To check background jobs go to Koha administration > Jobs > Manage jobs. If the job isn't displayed, unselect the "Current jobs only" checkbox.)