To Replicate 1. In Acquisitions, Budgets, add a new budget. 2. Fill in the Start date, Description, Total Amount, and make active. Leave the end date BLANK. 3. Save. See that the user is returned to the budget listing page but the budget creation silently fails. The behavior is repeated if both the start date and end date are blank. A save failure error message does appear if the description is left blank. I would expect a save fail error message if either the start or end date was blank.
Created attachment 169869 [details] [review] Bug 37096: Display error message for budget creation/modification if start/end date is left blank This patch adds an error message for a failed budget creation or modifcation due to the dates being empty. To test: 1) Go to the acquisitions tab, then on the side under 'Administration' select the 'Budgets' tab. 2) Click 'New budget', enter only a description and press save. 3) Note that the budget was not created, but no messages were displayed. 4) Apply patch, restart_all 5) Once again select 'New budget' and enter only a description. 6) This time when submitting, you will see an error message that says the process failed. 7) Edit an exisitng budget and remove the start date from this budget. 8) Attempt to save and note that the error message displays properly.
Created attachment 169873 [details] [review] Bug 37096: Display error message for budget creation/modification if start/end date is left blank This patch adds an error message for a failed budget creation or modifcation due to the dates being empty. To test: 1) Go to the acquisitions tab, then on the side under 'Administration' select the 'Budgets' tab. 2) Click 'New budget', enter only a description and press save. 3) Note that the budget was not created, but no messages were displayed. 4) Apply patch, restart_all 5) Once again select 'New budget' and enter only a description. 6) This time when submitting, you will see an error message that says the process failed. 7) Edit an exisitng budget and remove the start date from this budget. 8) Attempt to save and note that the error message displays properly. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
This works as described, but shouldn't we prevent the form from being saved until all required fields are filled in?
(In reply to Roman Dolny from comment #3) > This works as described, but shouldn't we prevent the form from being saved > until all required fields are filled in? Validating flatpickr values isn't the easiest thing to do. I couldn't find a way to make both of them required before submission while still utilizing jquery validation, so this solution was the next best thing for now