Bug 37140 - Add vendor automatically to 952 $e when creating items for serials
Summary: Add vendor automatically to 952 $e when creating items for serials
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Matt Blenkinsop
QA Contact: Testopia
URL:
Keywords:
: 22346 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-06-20 07:32 UTC by Christian Stelzenmüller
Modified: 2025-12-16 15:23 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: Sponsored
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement to serials populates the '952$e - Source of acquisition' with the vendor id when an item is received (where the serial has 'create an item record' set).
Version(s) released in:
Circulation function:


Attachments
Bug 37140: Add vendor id automatically to 952 when creating items for serials (4.09 KB, patch)
2025-12-04 15:45 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 37140: Add vendor id automatically to 952 when creating items for serials (4.16 KB, patch)
2025-12-04 15:46 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 37140: Add vendor id automatically to 952 when creating items for serials (4.15 KB, patch)
2025-12-04 16:02 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 37140: Add vendor id automatically to 952 when creating items for serials (4.20 KB, patch)
2025-12-04 18:41 UTC, David Nind
Details | Diff | Splinter Review
Bug 37140: Add vendor id automatically to 952 when creating items for serials (4.27 KB, patch)
2025-12-16 13:51 UTC, OpenFifth Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Stelzenmüller 2024-06-20 07:32:20 UTC
On receiving a serial in the serials module, it would be helpful to add the id of the vendor automatically to the item
In 952 $e (Source of acquisition), if the subscription is set to "create an item record", 
and the subscription has a vendor. 
Similar to the acquisition module, where the vendor is already added automatically to the items.

To test:
1. If necessary, set 952 $e in the bibliographic framework to visible in the staff interface and the editor.
2. Go to serials
3. Create a subscription with a vendor and the setting “create an item record” and save it.
4. Go to serial collection.
5. Set a serial issue from status “Expected” to “Arrived”
6. The vendor in subfield “e” (Source of acquisition) in the item form is empty. But it would be nice if the vendor was filled in automatically.
Comment 1 Katrin Fischer 2024-10-18 08:44:53 UTC
*** Bug 22346 has been marked as a duplicate of this bug. ***
Comment 2 Matt Blenkinsop 2025-12-04 15:45:24 UTC
Created attachment 190154 [details] [review]
Bug 37140: Add vendor id automatically to 952  when creating items for serials

Test plan:
1) If necessary, set 952 $e in the bibliographic framework to visible in the staff interface and the editor.
2) Navigate to the serials module
3) Create a subscription with a vendor and the setting “create an item record” and save it.
4) Nagivate to serial collection.
5) Set a serial issue from status “Expected” to “Arrived”
6) The vendor in subfield “e” (Source of acquisition) in the item form is empty
7) Apply the patch
8) Hard refresh the browser and the vendor should now be pre-populated with the vendor id
Comment 3 Matt Blenkinsop 2025-12-04 15:46:52 UTC
Created attachment 190155 [details] [review]
Bug 37140: Add vendor id automatically to 952  when creating items for serials

Test plan:
1) If necessary, set 952 $e in the bibliographic framework to visible in the staff interface and the editor.
2) Navigate to the serials module
3) Create a subscription with a vendor and the setting “create an item record” and save it.
4) Nagivate to serial collection.
5) Set a serial issue from status “Expected” to “Arrived”
6) The vendor in subfield “e” (Source of acquisition) in the item form is empty
7) Apply the patch
8) Hard refresh the browser and the vendor should now be pre-populated with the vendor id

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Comment 4 Matt Blenkinsop 2025-12-04 16:02:56 UTC
Created attachment 190156 [details] [review]
Bug 37140: Add vendor id automatically to 952  when creating items for serials

Test plan:
1) If necessary, set 952 $e in the bibliographic framework to visible in the staff interface and the editor.
2) Navigate to the serials module
3) Create a subscription with a vendor and the setting “create an item record” and save it.
4) Nagivate to serial collection.
5) Set a serial issue from status “Expected” to “Arrived”
6) The vendor in subfield “e” (Source of acquisition) in the item form is empty
7) Apply the patch
8) Hard refresh the browser and the vendor should now be pre-populated with the vendor id

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Comment 5 David Nind 2025-12-04 18:27:46 UTC
Hi Matt.

Things work as per the test plan.

However, the 952$e - Source of acquisition is populated with the ID of the vendor instead of the vendor name.

Is this within the scope of this change?

I think I would like to see the vendor name rather than the ID.

David
Comment 6 David Nind 2025-12-04 18:41:44 UTC
Created attachment 190162 [details] [review]
Bug 37140: Add vendor id automatically to 952 when creating items for serials

Test plan:
1) If necessary, set 952 $e in the bibliographic framework to visible in the staff interface and the editor.
2) Navigate to the serials module
3) Create a subscription with a vendor and the setting “create an item record” and save it.
4) Nagivate to serial collection.
5) Set a serial issue from status “Expected” to “Arrived”
6) The vendor in subfield “e” (Source of acquisition) in the item form is empty
7) Apply the patch
8) Hard refresh the browser and the vendor should now be pre-populated with the vendor id

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Signed-off-by: David Nind <david@davidnind.com>
Comment 7 Katrin Fischer 2025-12-05 07:39:49 UTC
(In reply to David Nind from comment #5)
> Hi Matt.
> 
> Things work as per the test plan.
> 
> However, the 952$e - Source of acquisition is populated with the ID of the
> vendor instead of the vendor name.
> 
> Is this within the scope of this change?
> 
> I think I would like to see the vendor name rather than the ID.
> 
> David

Hi David, 

the source of aquisision is a bit of an odd one. When you use the acquisitions module, it's always populated with the vendor ID. When libraries fill it in manually, they usually put in the vendor's name. I think the ID is correct here.

It looks like obsoleting the older patch hasn't worked automatically. Is this a glitch with the new git bz? The descriptions appear to be the same.
Comment 8 Matt Blenkinsop 2025-12-05 08:26:32 UTC
Thanks for answering Cait, I wasn't sure myself when writing it but the description mentioned the ID so I went with that, happy to hear it was the right option!

I've obsoleted the old patch
Comment 9 OpenFifth Sandboxes 2025-12-16 13:51:47 UTC
Created attachment 190543 [details] [review]
Bug 37140: Add vendor id automatically to 952 when creating items for serials

Test plan:
1) If necessary, set 952 $e in the bibliographic framework to visible in the staff interface and the editor.
2) Navigate to the serials module
3) Create a subscription with a vendor and the setting “create an item record” and save it.
4) Nagivate to serial collection.
5) Set a serial issue from status “Expected” to “Arrived”
6) The vendor in subfield “e” (Source of acquisition) in the item form is empty
7) Apply the patch
8) Hard refresh the browser and the vendor should now be pre-populated with the vendor id

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de>