There are some errors in the markup of the OPAC's recalls history page which is preventing the DataTable from behaving responsively.
Created attachment 167978 [details] [review] Bug 37158: Make OPAC recalls history table responsive Some markup errors in the OPAC recalls history template are causing the table to not be responsive even though the DataTable is configured to be responsive. This patch corrects it. Also changed: - Removed obsolete <span class="tdlabel">, a remnant of the way we did responsive tables before the DataTable option - Removed very obsolete "type" attribute from the <script> tag and very obsolete "<![CDATA" marker from the script block. - Removed <span>s which were used in the obsolete "title-string" method of sorting a DataTable. To test you must have recalls enabled and have at least one circulation rule which allows for recalls. - Log in to the OPAC as a user who can place recalls. - Locate an item which is elligible for recall and place the recall. - Go to your user summary page, and click the "Recalls history" link in the sidebar. - Confirm that the table of recalls on that page behaves correctly. It should adjust well to varying browser widths. Sponsored-by: Athens County Public Libraries
Created attachment 168001 [details] [review] Bug 37158: Make OPAC recalls history table responsive Some markup errors in the OPAC recalls history template are causing the table to not be responsive even though the DataTable is configured to be responsive. This patch corrects it. Also changed: - Removed obsolete <span class="tdlabel">, a remnant of the way we did responsive tables before the DataTable option - Removed very obsolete "type" attribute from the <script> tag and very obsolete "<![CDATA" marker from the script block. - Removed <span>s which were used in the obsolete "title-string" method of sorting a DataTable. To test you must have recalls enabled and have at least one circulation rule which allows for recalls. - Log in to the OPAC as a user who can place recalls. - Locate an item which is elligible for recall and place the recall. - Go to your user summary page, and click the "Recalls history" link in the sidebar. - Confirm that the table of recalls on that page behaves correctly. It should adjust well to varying browser widths. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Created attachment 168264 [details] [review] Bug 37158: Make OPAC recalls history table responsive Some markup errors in the OPAC recalls history template are causing the table to not be responsive even though the DataTable is configured to be responsive. This patch corrects it. Also changed: - Removed obsolete <span class="tdlabel">, a remnant of the way we did responsive tables before the DataTable option - Removed very obsolete "type" attribute from the <script> tag and very obsolete "<![CDATA" marker from the script block. - Removed <span>s which were used in the obsolete "title-string" method of sorting a DataTable. To test you must have recalls enabled and have at least one circulation rule which allows for recalls. - Log in to the OPAC as a user who can place recalls. - Locate an item which is elligible for recall and place the recall. - Go to your user summary page, and click the "Recalls history" link in the sidebar. - Confirm that the table of recalls on that page behaves correctly. It should adjust well to varying browser widths. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Much better, thanks Owen. Passing QA
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06