Bug 37169 - Fix the POD for z3950_search_args
Summary: Fix the POD for z3950_search_args
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-24 04:56 UTC by Phil Ringnalda
Modified: 2024-06-24 04:56 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Phil Ringnalda 2024-06-24 04:56:21 UTC
https://git.koha-community.org/Koha-community/Koha/src/commit/b0b168b6f84ef00babf566097933de7a338726a7/C4/Search.pm#L2136

Lines 2143-2144 still claim it returns a URL encoded value, though when bug 12071 stopped it from doing that, it did fix another mention of the URL encoded value

Lines 2148-2149 says that $matchpoints as a hash ref is bibliographic data from Biblio::GetBiblioData, but a hash ref $matchpoints can also be search data from an advanced search (and, not sure but it may very well be that even a simple keyword search passes a hash ref, since bug 11572 doesn't make much sense otherwise)

Lines 2151-2153 are either completely wrong if we no longer ever pass a scalar search term, or are wrong that we always return 'title' since we return either that or 'isbn' if we sniff out that it's an ISBN.