Currently a list can contain records, but not items. So the terminology used in virtualshelves/shelves.pl can be misleading : - in the table of lists, the "content" column contains "250 items" => it should be "250 records" - when we try to add records to a list (virtualshelves/shelves.pl?op=view&shelfnumber=1 ), there is a "Add items" button => it should be "Add records"
The same remarks applies to cart
Created attachment 170184 [details] [review] Bug 37177: "item" should be "record" in list page This patch rewords areas of the lists and cart templates so that the term "record" is preferred over "item" when referring to a bibliographic record. To test, apply the patch and go to Lists in the staff interface. - If necessary, create a new list. - From the list contents view, click "Add records" in the toolbar. - Submit some valid barcodes and biblionumbers - After adding biblionumbers you should see the message "The record ( [number] ) has been added to the list" - After adding barcodes you should see the message "The record for this item ( [barcode] ) has been added to the list" - Click "Add records" again - Submit some of the same barcodes and biblionumbers - You should see these messages: - "The record for this item ( [barcode] ) has not been added to the list. Please verify it is not already in the list." - "The record ( [number] ) has not been added to the list. Please verify it is not already in the list. - Check the checkbox for one or more titles on your list and click "Remove selected" - You should see the message, "The record has been removed from the list." - Perform a catalog search and from the results screen, select one or more results and add them to the cart. - Open the Cart and confirm that the controls at the top of the table of titles reads "Selected records: ..." Sponsored-by: Athens County Public Libraries
(In reply to Owen Leonard from comment #2) > Created attachment 170184 [details] [review] [review] > Bug 37177: "item" should be "record" in list page > > This patch rewords areas of the lists and cart templates so that the > term "record" is preferred over "item" when referring to a bibliographic > record. > > To test, apply the patch and go to Lists in the staff interface. > ... It works as described in test plan, but: 1. there is still "... items" in the table of lists (the "content" column) 2. when adding selected record(s) to the cart (search > results screen) there is a message "... item(s) added to your cart" or "No item was added to your cart" shown after clicking button "Add to cart"
Created attachment 170236 [details] [review] Bug 37177: "item" should be "record" in list page This patch rewords areas of the lists and cart templates so that the term "record" is preferred over "item" when referring to a bibliographic record. To test, apply the patch and go to Lists in the staff interface. - If necessary, create a new list. - From the list contents view, click "Add records" in the toolbar. - Submit some valid barcodes and biblionumbers - After adding biblionumbers you should see the message "The record ( [number] ) has been added to the list" - After adding barcodes you should see the message "The record for this item ( [barcode] ) has been added to the list" - Click "Add records" again - Submit some of the same barcodes and biblionumbers - You should see these messages: - "The record for this item ( [barcode] ) has not been added to the list. Please verify it is not already in the list." - "The record ( [number] ) has not been added to the list. Please verify it is not already in the list. - Check the checkbox for one or more titles on your list and click "Remove selected" - You should see the message, "The record has been removed from the list." - Perform a catalog search and from the results screen, select one or more results and add them to the cart. - Open the Cart and confirm that the controls at the top of the table of titles reads "Selected records: ..." Sponsored-by: Athens County Public Libraries
Created attachment 170239 [details] [review] Bug 37177: "item" should be "record" in list page This patch rewords areas of the lists and cart templates so that the term "record" is preferred over "item" when referring to a bibliographic record. To test, apply the patch and go to Lists in the staff interface. - If necessary, create a new list. - From the list contents view, click "Add records" in the toolbar. - Submit some valid barcodes and biblionumbers - After adding biblionumbers you should see the message "The record ( [number] ) has been added to the list" - After adding barcodes you should see the message "The record for this item ( [barcode] ) has been added to the list" - Click "Add records" again - Submit some of the same barcodes and biblionumbers - You should see these messages: - "The record for this item ( [barcode] ) has not been added to the list. Please verify it is not already in the list." - "The record ( [number] ) has not been added to the list. Please verify it is not already in the list. - Check the checkbox for one or more titles on your list and click "Remove selected" - You should see the message, "The record has been removed from the list." - Perform a catalog search and from the results screen, select one or more results and add them to the cart. - Open the Cart and confirm that the controls at the top of the table of titles reads "Selected records: ..." Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 170428 [details] [review] Bug 37177: "item" should be "record" in list page This patch rewords areas of the lists and cart templates so that the term "record" is preferred over "item" when referring to a bibliographic record. To test, apply the patch and go to Lists in the staff interface. - If necessary, create a new list. - From the list contents view, click "Add records" in the toolbar. - Submit some valid barcodes and biblionumbers - After adding biblionumbers you should see the message "The record ( [number] ) has been added to the list" - After adding barcodes you should see the message "The record for this item ( [barcode] ) has been added to the list" - Click "Add records" again - Submit some of the same barcodes and biblionumbers - You should see these messages: - "The record for this item ( [barcode] ) has not been added to the list. Please verify it is not already in the list." - "The record ( [number] ) has not been added to the list. Please verify it is not already in the list. - Check the checkbox for one or more titles on your list and click "Remove selected" - You should see the message, "The record has been removed from the list." - Perform a catalog search and from the results screen, select one or more results and add them to the cart. - Open the Cart and confirm that the controls at the top of the table of titles reads "Selected records: ..." Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Passing QA, moving to enh. Please tell me if I am mistaken :)
Thank you everybody
Owen, can you please rebase?
Created attachment 170901 [details] [review] Bug 37177: "item" should be "record" in list page This patch rewords areas of the lists and cart templates so that the term "record" is preferred over "item" when referring to a bibliographic record. To test, apply the patch and go to Lists in the staff interface. - If necessary, create a new list. - From the list contents view, click "Add records" in the toolbar. - Submit some valid barcodes and biblionumbers - After adding biblionumbers you should see the message "The record ( [number] ) has been added to the list" - After adding barcodes you should see the message "The record for this item ( [barcode] ) has been added to the list" - Click "Add records" again - Submit some of the same barcodes and biblionumbers - You should see these messages: - "The record for this item ( [barcode] ) has not been added to the list. Please verify it is not already in the list." - "The record ( [number] ) has not been added to the list. Please verify it is not already in the list. - Check the checkbox for one or more titles on your list and click "Remove selected" - You should see the message, "The record has been removed from the list." - Perform a catalog search and from the results screen, select one or more results and add them to the cart. - Open the Cart and confirm that the controls at the top of the table of titles reads "Selected records: ..." Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 24.11! Well done everyone, thank you!