Bug 37188 - Batch patron modification from report results should be an option when borrowernumber is selected
Summary: Batch patron modification from report results should be an option when borrow...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: 24.05
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 37197
Blocks:
  Show dependency treegraph
 
Reported: 2024-06-25 21:08 UTC by hebah
Modified: 2024-06-27 04:17 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description hebah 2024-06-25 21:08:57 UTC
To recreate: run a report using borrowernumber as one of the columns. Select batch actions from visible results. See that batch patron modification is not an option. Confirmed change in behavior from 23.11.
Comment 1 Phil Ringnalda 2024-06-26 14:22:08 UTC
Are you *sure* that's a change from 23.11? Bug 29181 made the decision to show patron card creator when you select borrowernumber, and to show batch patron modification when you select cardnumber, and thus to only show both when you select borrowernumber, cardnumber, and that bug says it landed in 23.11 so it should be a change from 23.05 to 23.11.

Certainly a regression in 24.05 that batch patron modification is broken since bug 34478 broke sending things to it by changing it from a POST which it accepts to a GET which it does not, though. Filed bug 37197 for that
Comment 2 Phil Ringnalda 2024-06-27 03:53:06 UTC
Bug 29181 comment 2 in the commit message said "The logic of the dropdown menu has been modified in order to ensure that duplicate patron modification options aren't shown in the menu when a report return both borrowernumber and cardnumber" but I don't see why that would occur. Batch patron modification can take either borrowernumber or cardnumber, so we should show it IF show_cardnumber_ops || show_borrowernumber_ops while patron card creator can only take borrowernumber so we should only show it IF show_borrowernumber_ops, and then if you select cardnumber you get batch patron modification only, if you select borrowernumber you get both, if you select both you get both.
Comment 3 Phil Ringnalda 2024-06-27 04:17:25 UTC
Oh, not quite so simple, since we have to know which sort of data we are sending to batch mod, and have a way to send it the thing we have from a particular report.

Still, if ( (borrowernumber and cardnumber) or (borrowernumber and 
!cardnumber)) batchmod_borrowernumber elseif (cardnumber) batchmod_cardnumber endif if (cardnumber) cardcreator_cardnumber isn't *that* messy.