Hello :) I've worked on a way to prevent checkout to patron if this same patron has a booking expired for the same item.. I think it's a setting that might not suit everyone, so I've introduced a new system preference. I'll put my patch in place and await your comments. Thanks ^^
Created attachment 168159 [details] [review] Bug 37201: Allow or not a checkout if a expired booking exists Test plan: 1) Apply this patch and run updatedatabase 2) Set a booking on a specific item 3) In database you can update the value to set a past date for booking end for example. 4) Go system preferences and search 'AllowExpiredBookingTransformation' 5) When you "Don\'t allow" normally you will find a pop up to confirm the checkout when you choose to 'Transform to checkout' from bookings list view. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS)
Created attachment 168227 [details] [review] Bug 37201: Allow or not a checkout if a expired booking exists Test plan: 1) Apply this patch and run updatedatabase 2) Set a booking on a specific item 3) In database you can update the value to set a past date for booking end for example. 4) Go system preferences and search 'AllowExpiredBookingTransformation' 5) When you "Don\'t allow" normally you will find a pop up to confirm the checkout when you choose to 'Transform to checkout' from bookings list view. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS)
Note: A patch for a dependency (bug 36789) no longer applies, so can't be tested until that is resolved.
Created attachment 170192 [details] [review] Bug 37201: Allow or not a checkout if a expired booking exists Test plan: 1) Apply this patch and run updatedatabase 2) Set a booking on a specific item 3) In database you can update the value to set a past date for booking end for example. 4) Go system preferences and search 'AllowExpiredBookingTransformation' 5) When you "Don\'t allow" normally you will find a pop up to confirm the checkout when you choose to 'Transform to checkout' from bookings list view. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS)
When I try to apply this patch, it doesn't apply the dependencies, probably due to 36789 being set to 'Patch doesn't apply'. Just FYI.