Bug 37209 - Improve record overlay rules validation and styling
Summary: Improve record overlay rules validation and styling
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Jan Kissig
QA Contact: Testopia
URL:
Keywords:
Depends on: 36880
Blocks:
  Show dependency treegraph
 
Reported: 2024-06-27 10:25 UTC by Jan Kissig
Modified: 2024-07-07 09:12 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 37209: improve Record overlay rules validation and styling (9.99 KB, patch)
2024-07-03 13:09 UTC, Jan Kissig
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Kissig 2024-06-27 10:25:08 UTC
As mentioned in BUG 36880#11 this page needs an update on the following points:

- validation of input "Tag" as per coding guidelines
- change styling of "required" class on input "Tag" to be consistent with other required input lements
Comment 1 Jan Kissig 2024-07-03 13:09:51 UTC
Created attachment 168447 [details] [review]
Bug 37209: improve Record overlay rules validation and styling

This patch adds jquery form validation to the input named tag. It also changes the behavior for save and edit actions which now both can be triggered by pressing enter. Batch deletion will be only possible if no edit is taking place.

Test plan:
1)
 a) open http://localhost:8081/cgi-bin/koha/admin/marc-overlay-rules.pl
 b) just click + Add rule
 c) the input 'tag' gets highlighted and the form won't submit

2)
 a) edit an existing rule
 b) empty input value for tag
 c) notice the checkboxes for batch deletion on other rules if existing
 d) click Save and check the input 'tag' gets highlighted and the form won't submit

apply patch
1) redo steps and check that form does not get submitted and the input is marked as required via a label that says This field is required.

2) redo steps and check that form does not get submitted and the input is marked as required via a label that says This field is required. Also checkboxes for batchremove actions are gone.



Current depends: 36880
Comment 2 David Nind 2024-07-04 01:02:37 UTC
Added assignee.