Bug 37219 - In OPAC item holds, separate copy number from radio button and add table configuration
Summary: In OPAC item holds, separate copy number from radio button and add table conf...
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 37229
Blocks:
  Show dependency treegraph
 
Reported: 2024-06-28 14:43 UTC by Sara Brown
Modified: 2024-11-20 09:10 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 37219: In OPAC item holds, separate copy number from radio button and add table configuration (28.11 KB, patch)
2024-07-03 16:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37219: In OPAC item holds, separate copy number from radio button and add table configuration (28.16 KB, patch)
2024-07-05 18:31 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 37219: In OPAC item holds, separate copy number from radio button and add table configuration (28.20 KB, patch)
2024-09-13 12:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37219: In OPAC item holds, separate copy number from radio button and add table configuration (28.30 KB, patch)
2024-11-15 09:48 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sara Brown 2024-06-28 14:43:59 UTC
When placing an item-level hold in the OPAC, the column to select your item(s) using a radio button or checkbox is called "Copy number". This doesn't accurately describe what it is. The same column when placing a hold from the staff intranet is called "Hold", which makes more sense since you're selecting the item(s) you want to hold.
Comment 1 Phil Ringnalda 2024-07-01 18:12:25 UTC
It's still a bit confusing, but less confusing, if you use copy numbers, since then the column looks like:

( ) 1
( ) 1
( ) 2
( ) 2
( ) 4

which is probably nice if you are doing a item-level hold because of copy number. I never have done that in the OPAC, only for a particular enumchron or a particular home or holding branch, but maybe some people do.
Comment 2 Owen Leonard 2024-07-03 15:29:22 UTC
I propose this change:

- Split the radio button and copy number into two different columns
- Add column configuration to the table so that libraries that don't use copy numbers can hide the column
Comment 3 Owen Leonard 2024-07-03 16:20:59 UTC
Created attachment 168465 [details] [review]
Bug 37219: In OPAC item holds, separate copy number from radio button and add table configuration

This patch changes the way items are displayed during the process of
placing a single or multiple item-level holds in the OPAC. The
item-selection radio button is now in a separate column from copy
number, and the columns can be configured.

Note: This patch includes indentation changes, so ignore whitespace when
viewing the diff.

To test, apply the patch and restart services.

- If necessary, go to Administration -> Circulation and fine rules and
  enable item-level holds in one of the rules.
- Log in to the OPAC and start the process of placing a hold on a title
  which falls under your configured circulation rule.
- On the place hold page, click "Show more options" and "A specific
  item" to show the table of items.
- The radio buttons and copy numbers should appear in separate columns.
- Go to Administration -> Table settings -> OPAC -> opac_holds and
  change the table's configuration to hide one or more columns.
- Return to the OPAC holds process and confirm that the table reflects
  your configuration changes.
- Perform the same test with multiple holds (selecting multiple items in
  catalog search results).

Sponsored-by: Athens County Public Libraries
Comment 4 Phil Ringnalda 2024-07-05 18:31:12 UTC
Created attachment 168564 [details] [review]
Bug 37219: In OPAC item holds, separate copy number from radio button and add table configuration

This patch changes the way items are displayed during the process of
placing a single or multiple item-level holds in the OPAC. The
item-selection radio button is now in a separate column from copy
number, and the columns can be configured.

Note: This patch includes indentation changes, so ignore whitespace when
viewing the diff.

To test, apply the patch and restart services.

- If necessary, go to Administration -> Circulation and fine rules and
  enable item-level holds in one of the rules.
- Log in to the OPAC and start the process of placing a hold on a title
  which falls under your configured circulation rule.
- On the place hold page, click "Show more options" and "A specific
  item" to show the table of items.
- The radio buttons and copy numbers should appear in separate columns.
- Go to Administration -> Table settings -> OPAC -> opac_holds and
  change the table's configuration to hide one or more columns.
- Return to the OPAC holds process and confirm that the table reflects
  your configuration changes.
- Perform the same test with multiple holds (selecting multiple items in
  catalog search results).

Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 5 Owen Leonard 2024-09-13 12:27:01 UTC
Created attachment 171455 [details] [review]
Bug 37219: In OPAC item holds, separate copy number from radio button and add table configuration

This patch changes the way items are displayed during the process of
placing a single or multiple item-level holds in the OPAC. The
item-selection radio button is now in a separate column from copy
number, and the columns can be configured.

Note: This patch includes indentation changes, so ignore whitespace when
viewing the diff.

To test, apply the patch and restart services.

- If necessary, go to Administration -> Circulation and fine rules and
  enable item-level holds in one of the rules.
- Log in to the OPAC and start the process of placing a hold on a title
  which falls under your configured circulation rule.
- On the place hold page, click "Show more options" and "A specific
  item" to show the table of items.
- The radio buttons and copy numbers should appear in separate columns.
- Go to Administration -> Table settings -> OPAC -> opac_holds and
  change the table's configuration to hide one or more columns.
- Return to the OPAC holds process and confirm that the table reflects
  your configuration changes.
- Perform the same test with multiple holds (selecting multiple items in
  catalog search results).

Sponsored-by: Athens County Public Libraries

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 6 Marcel de Rooy 2024-11-15 09:48:38 UTC
Created attachment 174551 [details] [review]
Bug 37219: In OPAC item holds, separate copy number from radio button and add table configuration

This patch changes the way items are displayed during the process of
placing a single or multiple item-level holds in the OPAC. The
item-selection radio button is now in a separate column from copy
number, and the columns can be configured.

Note: This patch includes indentation changes, so ignore whitespace when
viewing the diff.

To test, apply the patch and restart services.

- If necessary, go to Administration -> Circulation and fine rules and
  enable item-level holds in one of the rules.
- Log in to the OPAC and start the process of placing a hold on a title
  which falls under your configured circulation rule.
- On the place hold page, click "Show more options" and "A specific
  item" to show the table of items.
- The radio buttons and copy numbers should appear in separate columns.
- Go to Administration -> Table settings -> OPAC -> opac_holds and
  change the table's configuration to hide one or more columns.
- Return to the OPAC holds process and confirm that the table reflects
  your configuration changes.
- Perform the same test with multiple holds (selecting multiple items in
  catalog search results).

Sponsored-by: Athens County Public Libraries

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Katrin Fischer 2024-11-19 15:16:23 UTC
@Joubu can you please check if that is OK to push with the recent DT work and the work to come?
Comment 8 Jonathan Druart 2024-11-19 16:19:04 UTC
Pretty sure this does not work correctly.

If you have table's headers depending on syspref, you have to use bKohaColumnsUseNames or the column visibility won't work correctly.
Comment 9 Katrin Fischer 2024-11-19 16:22:15 UTC
Thanks, Joubu. Owen, can you please check?
Comment 10 Jonathan Druart 2024-11-20 09:10:04 UTC
This needs to be rebuilt on top of the other DataTables patches that are in the queue. Please ping me if needed.