Bug 37233 - Library URL broken in the libraries table
Summary: Library URL broken in the libraries table
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Janusz Kaczmarek
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-02 15:22 UTC by Janusz Kaczmarek
Modified: 2024-07-09 12:56 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the URL link for a library in the staff interface (Administration > Basic parameters > Libraries) so that it works as expected. Currently, you get a 404 page not found error.
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37233: Library URL broken on in libraries tables (1.99 KB, patch)
2024-07-02 15:30 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 37233: Library URL broken on in libraries tables (2.03 KB, patch)
2024-07-02 18:57 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2024-07-02 15:22:51 UTC
The URL given for a library is badly encoded in the table on the /cgi-bin/koha/admin/branches.pl page.  As a result, clicking on the link leads to 404 page.
Comment 1 Janusz Kaczmarek 2024-07-02 15:30:48 UTC
Created attachment 168380 [details] [review]
Bug 37233: Library URL broken on in libraries tables

The URL given for a library is badly encoded in the table on the
/cgi-bin/koha/admin/branches.pl page.  As a result, clicking on the link
leads to 404 page.

Test plan:
==========
1. Have a library with a URL defined.
2. In the table on the Libraries page (/cgi-bin/koha/admin/branches.pl)
   click the link with the URL.
   You should get "Error 404".
3. Apply the patch; restart_all.
4. Go to the Libraries page.  Ctrl+R to reload JS.
   You should be able to reach the URL given in the library setup now.
Comment 2 David Nind 2024-07-02 18:57:50 UTC
Created attachment 168402 [details] [review]
Bug 37233: Library URL broken on in libraries tables

The URL given for a library is badly encoded in the table on the
/cgi-bin/koha/admin/branches.pl page.  As a result, clicking on the link
leads to 404 page.

Test plan:
==========
1. Have a library with a URL defined.
2. In the table on the Libraries page (/cgi-bin/koha/admin/branches.pl)
   click the link with the URL.
   You should get "Error 404".
3. Apply the patch; restart_all.
4. Go to the Libraries page.  Ctrl+R to reload JS.
   You should be able to reach the URL given in the library setup now.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2024-07-09 12:44:39 UTC
Picked from QA queue for push to main.
Comment 4 Katrin Fischer 2024-07-09 12:56:56 UTC
Pushed for 24.11!

Well done everyone, thank you!