Bug 37235 - Download single authority results in 500 error
Summary: Download single authority results in 500 error
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Authority data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Owen Leonard
QA Contact: Pedro Amorim
URL:
Keywords:
Depends on: 36192
Blocks: 37252
  Show dependency treegraph
 
Reported: 2024-07-02 19:13 UTC by Caroline Cyr La Rose
Modified: 2024-07-05 14:10 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 37235: Fix export of single authority record (1.34 KB, patch)
2024-07-03 18:02 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37235: Fix export of single authority record (1.41 KB, patch)
2024-07-03 18:19 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 37235: Fix export of single authority record (1.46 KB, patch)
2024-07-05 14:10 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-07-02 19:13:52 UTC
I'm getting a 500 error when I try to "save" (i.e. download) an authority record.

To recreate: 
1. Go to Authorities
2. Search for an authority 
3. Click on the authority header to access the detailed record page (authorities/detail.pl?authid=XXXX)
4. Click Save > MADS (XML)
   --> Error 500
5. Redo step 4 with the other formats (MARCXML, MARC (non-Unicode/MARC-8), MARC (Unicode/UTF8)
   --> Error 500


I get this on KTD with both Zebra and ES7.
Comment 2 Owen Leonard 2024-07-03 18:02:45 UTC
Created attachment 168468 [details] [review]
Bug 37235: Fix export of single authority record

When viewing an authority record, you have the option to "Save" in
several different formats. This operation is a GET operation and the
script should not be looking for a "cud-" operation.

To test you should have at least one authority record.

- Apply the patch and go to Authorities.
- Perform an authority search which will return one or more records.
- View the details of an authority record.
- From the toolbar, test the "Save" option*

* Note: In my test the export choice "MADS (XML)" resulted in a
  zero-byte file but I'm assuming that is a separate issue.

Sponsored-by: Athens County Public Libraries
Comment 3 Caroline Cyr La Rose 2024-07-03 18:19:47 UTC
Created attachment 168469 [details] [review]
Bug 37235: Fix export of single authority record

When viewing an authority record, you have the option to "Save" in
several different formats. This operation is a GET operation and the
script should not be looking for a "cud-" operation.

To test you should have at least one authority record.

- Apply the patch and go to Authorities.
- Perform an authority search which will return one or more records.
- View the details of an authority record.
- From the toolbar, test the "Save" option*

* Note: In my test the export choice "MADS (XML)" resulted in a
  zero-byte file but I'm assuming that is a separate issue.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 4 Pedro Amorim 2024-07-05 14:10:53 UTC
Created attachment 168551 [details] [review]
Bug 37235: Fix export of single authority record

When viewing an authority record, you have the option to "Save" in
several different formats. This operation is a GET operation and the
script should not be looking for a "cud-" operation.

To test you should have at least one authority record.

- Apply the patch and go to Authorities.
- Perform an authority search which will return one or more records.
- View the details of an authority record.
- From the toolbar, test the "Save" option*

* Note: In my test the export choice "MADS (XML)" resulted in a
  zero-byte file but I'm assuming that is a separate issue.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>