Bug 37254 - Dropdown values not cleared after pressing clear in circulation rules
Summary: Dropdown values not cleared after pressing clear in circulation rules
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Emmi Takkinen
QA Contact: Laura Escamilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-04 10:11 UTC by Emmi Takkinen
Modified: 2024-08-09 15:37 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37254: Fix clearing of dropdown values on circulation rules (1.55 KB, patch)
2024-07-04 12:09 UTC, Emmi Takkinen
Details | Diff | Splinter Review
Bug 37254: Fix clearing of dropdown values on circulation rules (1.60 KB, patch)
2024-07-04 22:12 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 37254: Fix clearing of dropdown values on circulation rules (1.67 KB, patch)
2024-07-25 15:50 UTC, Laura Escamilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emmi Takkinen 2024-07-04 10:11:40 UTC
When one tries to clear the rule they are editing in circulation rules page via "Clear" button, dropdown selectors aren't populated with default value (first on the list).

To reproduce:
1. Select a rule to edit.
2. Press "Clear" button to return edit rows values back to default values.
=> Values in dropdowns aren't set back as default, instead they have same values as rule you edited before pressing "Clear".
Comment 1 Emmi Takkinen 2024-07-04 12:09:31 UTC
Created attachment 168502 [details] [review]
Bug 37254: Fix clearing of dropdown values on circulation rules

When one tries to clear the rule they are editing in circulation
rules page via "Clear" button, dropdown selectors aren't populated
with default value (first on the list).

To reproduce:
1. Select a rule to edit.
2. Press "Clear" button to return edit rows values back to default values.
=> Values in dropdowns aren't set back as default, instead they have
same values as rule you edited before pressing "Clear".
3. Apply this patch.
4. Select rule to edit, then press "Clear".
=> Dropdowns now have default values.

Sponsored-by: Koha-Suomi Oy
Comment 2 Chris Cormack 2024-07-04 22:12:28 UTC
Created attachment 168522 [details] [review]
Bug 37254: Fix clearing of dropdown values on circulation rules

When one tries to clear the rule they are editing in circulation
rules page via "Clear" button, dropdown selectors aren't populated
with default value (first on the list).

To reproduce:
1. Select a rule to edit.
2. Press "Clear" button to return edit rows values back to default values.
=> Values in dropdowns aren't set back as default, instead they have
same values as rule you edited before pressing "Clear".
3. Apply this patch.
4. Select rule to edit, then press "Clear".
=> Dropdowns now have default values.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 3 Laura Escamilla 2024-07-25 15:50:43 UTC
Created attachment 169582 [details] [review]
Bug 37254: Fix clearing of dropdown values on circulation rules

Looks great! QA tool is also happy. Passing QA
Comment 4 Katrin Fischer 2024-08-09 15:37:05 UTC
Pushed for 24.11!

Well done everyone, thank you!