When one tries to clear the rule they are editing in circulation rules page via "Clear" button, dropdown selectors aren't populated with default value (first on the list). To reproduce: 1. Select a rule to edit. 2. Press "Clear" button to return edit rows values back to default values. => Values in dropdowns aren't set back as default, instead they have same values as rule you edited before pressing "Clear".
Created attachment 168502 [details] [review] Bug 37254: Fix clearing of dropdown values on circulation rules When one tries to clear the rule they are editing in circulation rules page via "Clear" button, dropdown selectors aren't populated with default value (first on the list). To reproduce: 1. Select a rule to edit. 2. Press "Clear" button to return edit rows values back to default values. => Values in dropdowns aren't set back as default, instead they have same values as rule you edited before pressing "Clear". 3. Apply this patch. 4. Select rule to edit, then press "Clear". => Dropdowns now have default values. Sponsored-by: Koha-Suomi Oy
Created attachment 168522 [details] [review] Bug 37254: Fix clearing of dropdown values on circulation rules When one tries to clear the rule they are editing in circulation rules page via "Clear" button, dropdown selectors aren't populated with default value (first on the list). To reproduce: 1. Select a rule to edit. 2. Press "Clear" button to return edit rows values back to default values. => Values in dropdowns aren't set back as default, instead they have same values as rule you edited before pressing "Clear". 3. Apply this patch. 4. Select rule to edit, then press "Clear". => Dropdowns now have default values. Sponsored-by: Koha-Suomi Oy Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 169582 [details] [review] Bug 37254: Fix clearing of dropdown values on circulation rules Looks great! QA tool is also happy. Passing QA
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.04
Pushed to 23.11.x for 23.11.09
Is this okay to be backported during string freeze?
(In reply to wainuiwitikapark from comment #7) > Is this okay to be backported during string freeze? Yes there are no translated string in changes
(In reply to Fridolin Somers from comment #8) > (In reply to wainuiwitikapark from comment #7) > > Is this okay to be backported during string freeze? > > Yes there are no translated string in changes Thanks Fridolin! I think I might wait until next release to do this one :)
Not backporting to 23.05.x unless requested