Created attachment 168533 [details] [review] Bug 37262: Tests for filtering unmapped tablename Test plan: 1) Apply this patch only, run tests: prove t/db_dependent/api/v1/extended_attribute_types.t 2) Notice they fail 3) Apply the fix patch, run tests again
Created attachment 168534 [details] [review] Bug 37262: Fix for unmapped tablename filtering
The tests don't pass after applying the fix patch. With the first patch (and dependent bug 37261) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ prove t/db_dependent/api/v1/extended_attribute_types.t t/db_dependent/api/v1/extended_attribute_types.t .. # Failed test '200 OK' # at t/db_dependent/api/v1/extended_attribute_types.t line 124. # got: '400' # expected: '200' # Failed test 'exact match for JSON Pointer ""' # at t/db_dependent/api/v1/extended_attribute_types.t line 124. # Structures begin differing at: # $got = HASH(0x58ce5bcd0ea0) # $expected = ARRAY(0x58ce5c4ed4e8) # Looks like you failed 2 tests of 23. t/db_dependent/api/v1/extended_attribute_types.t .. 1/1 # Failed test 'list() tests' # at t/db_dependent/api/v1/extended_attribute_types.t line 135. # Looks like you failed 1 test of 1. t/db_dependent/api/v1/extended_attribute_types.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Test Summary Report ------------------- t/db_dependent/api/v1/extended_attribute_types.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=1, 4 wallclock secs ( 0.02 usr 0.00 sys + 3.18 cusr 0.28 csys = 3.48 CPU) Result: FAIL After the fix patch ~~~~~~~~~~~~~~~~~~~ prove t/db_dependent/api/v1/extended_attribute_types.t t/db_dependent/api/v1/extended_attribute_types.t .. # Failed test '200 OK' # at t/db_dependent/api/v1/extended_attribute_types.t line 124. # got: '400' # expected: '200' # Failed test 'exact match for JSON Pointer ""' # at t/db_dependent/api/v1/extended_attribute_types.t line 124. # Structures begin differing at: # $got = HASH(0x643ead195ea8) # $expected = ARRAY(0x643ead191650) # Looks like you failed 2 tests of 23. t/db_dependent/api/v1/extended_attribute_types.t .. 1/1 # Failed test 'list() tests' # at t/db_dependent/api/v1/extended_attribute_types.t line 135. # Looks like you failed 1 test of 1. t/db_dependent/api/v1/extended_attribute_types.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Test Summary Report ------------------- t/db_dependent/api/v1/extended_attribute_types.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=1, 4 wallclock secs ( 0.01 usr 0.01 sys + 3.20 cusr 0.22 csys = 3.44 CPU) Result: FAIL
Created attachment 168589 [details] [review] Bug 37262: Tests for filtering unmapped tablename Test plan: 1) Apply this patch only, run tests: prove t/db_dependent/api/v1/extended_attribute_types.t 2) Notice they fail 3) Apply the fix patch, refresh the API bundle, run: yarn api:bundle 4) Run tests again, notice they pass
Created attachment 168590 [details] [review] Bug 37262: Fix for unmapped tablename filtering
Thank you David, I missed a step on the test plan and have now updated it. We are required to run: yarn api:bundle Because the API specs have changed I believe. Can you please try again? The api bundle command failed for me today before running ktd pull so please try that if it fails for you the first time.
(In reply to Pedro Amorim from comment #6) > Thank you David, I missed a step on the test plan and have now updated it. > We are required to run: > yarn api:bundle > > Because the API specs have changed I believe. > Can you please try again? The api bundle command failed for me today before > running ktd pull so please try that if it fails for you the first time. Thanks Pedro! That worked.
Created attachment 168613 [details] [review] Bug 37262: Tests for filtering unmapped tablename Test plan: 1) Apply this patch only, run tests: prove t/db_dependent/api/v1/extended_attribute_types.t 2) Notice they fail 3) Apply the fix patch, refresh the API bundle, run: yarn api:bundle 4) Run tests again, notice they pass Signed-off-by: David Nind <david@davidnind.com>
Created attachment 168614 [details] [review] Bug 37262: Fix for unmapped tablename filtering Signed-off-by: David Nind <david@davidnind.com>
Created attachment 168742 [details] [review] Bug 37262: Tests for filtering unmapped tablename Test plan: 1) Apply this patch only, run tests: prove t/db_dependent/api/v1/extended_attribute_types.t 2) Notice they fail 3) Apply the fix patch, refresh the API bundle, run: yarn api:bundle 4) Run tests again, notice they pass Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 168743 [details] [review] Bug 37262: Fix for unmapped tablename filtering Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Edit: amended to tidy the new code (tcohen)
Created attachment 168744 [details] [review] Bug 37262: (follow-up) Rename types/tables Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pedro: please review my follow-up.
Created attachment 168752 [details] [review] Bug 37262: (follow-up) Rename types/tables Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Pushed for 24.11! Well done everyone, thank you!