Bug 37264 - Fix delete button on staff interface's suggestion detail page
Summary: Fix delete button on staff interface's suggestion detail page
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 34478
Blocks:
  Show dependency treegraph
 
Reported: 2024-07-05 15:51 UTC by Owen Leonard
Modified: 2024-07-09 12:57 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37264: Fix delete button on staff interface's suggestion detail page (2.50 KB, patch)
2024-07-05 16:01 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37264: Fix delete button on staff interface's suggestion detail page (2.55 KB, patch)
2024-07-05 17:39 UTC, Phil Ringnalda
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-07-05 15:51:46 UTC
When viewing (not editing) a suggestion in the staff interface there is a "Delete" button in the toolbar. It needs some adjustments:

- Should not have the "btn-primary" class
- Should have a "deletesuggestion" class to trigger the confirmation
- Should not be wrapped in a <fieldset>
Comment 1 Owen Leonard 2024-07-05 16:01:59 UTC
Created attachment 168558 [details] [review]
Bug 37264: Fix delete button on staff interface's suggestion detail page

This patch makes a few minor changes to the suggestion detail page in
the staff interface so that the "Delete" button looks correct and works
correctly.

To test, apply the patch and go to Suggestions in the staff interface.

- If necessary, submit a suggestion. You need at least one.
- From the suggestions management page, click the title of a suggestion.
- At the top of this page should be two buttons, "Edit" and "Delete."
  They should be styled consistently with each other.
- Clicking the "Delete" button should trigger a JavaScript confirmation
  dialog. Confirming should result in the suggestion being deleted.

Sponsored-by: Athens County Public Libraries
Comment 2 Phil Ringnalda 2024-07-05 17:39:16 UTC
Created attachment 168561 [details] [review]
Bug 37264: Fix delete button on staff interface's suggestion detail page

This patch makes a few minor changes to the suggestion detail page in
the staff interface so that the "Delete" button looks correct and works
correctly.

To test, apply the patch and go to Suggestions in the staff interface.

- If necessary, submit a suggestion. You need at least one.
- From the suggestions management page, click the title of a suggestion.
- At the top of this page should be two buttons, "Edit" and "Delete."
  They should be styled consistently with each other.
- Clicking the "Delete" button should trigger a JavaScript confirmation
  dialog. Confirming should result in the suggestion being deleted.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Katrin Fischer 2024-07-09 12:42:21 UTC
Picked from QA queue to push to main.
Comment 4 Katrin Fischer 2024-07-09 12:57:05 UTC
Pushed for 24.11!

Well done everyone, thank you!