Bug 37289 - t/db_dependent/api/v1/authorised_values.t is failing under specific circumstances
Summary: t/db_dependent/api/v1/authorised_values.t is failing under specific circumsta...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Chris Cormack
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-09 12:59 UTC by Katrin Fischer
Modified: 2024-07-11 11:43 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37289: Add sorting to test (2.79 KB, patch)
2024-07-09 13:28 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 37289: [DONT PUSH] Test only (1.29 KB, patch)
2024-07-09 13:28 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 37289: Add sorting to test (2.86 KB, patch)
2024-07-09 14:23 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2024-07-09 12:59:32 UTC
t/db_dependent/api/v1/authorised_values.t
not ok 1 - list_av_from_category() tests

Discussion on Mattermost pointed to this being related to a sequence issue.
Comment 1 Jonathan Druart 2024-07-09 13:10:36 UTC
Koha_Main_U20 #1301 on Docker_9
Comment 2 Katrin Fischer 2024-07-09 13:11:55 UTC
https://jenkins.koha-community.org/job/Koha_Main_U20/1301/ :)
Comment 3 Pedro Amorim 2024-07-09 13:28:04 UTC
Created attachment 168647 [details] [review]
Bug 37289: Add sorting to test

Ensure the order of embedded records returned.
Dont apply the DONT PUSH patch.
prove ./t/db_dependent/api/v1/authorised_values.t ---> Notice if passes
Comment 4 Pedro Amorim 2024-07-09 13:28:07 UTC
Created attachment 168648 [details] [review]
Bug 37289: [DONT PUSH] Test only

Apply this patch on top of the previous one.
This patch is to prove the bug the previous patch is fixing.
It proves that the order_by using the embedded field is working as intended.
prove ./t/db_dependent/api/v1/authorised_values.t ---> Notice it fails
Comment 5 Jonathan Druart 2024-07-09 14:23:34 UTC
Created attachment 168663 [details] [review]
Bug 37289: Add sorting to test

Ensure the order of embedded records returned.
Dont apply the DONT PUSH patch.
prove ./t/db_dependent/api/v1/authorised_values.t ---> Notice if passes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Katrin Fischer 2024-07-11 09:56:17 UTC
Picked from QA queue for push to main.
Comment 7 Katrin Fischer 2024-07-11 11:43:32 UTC
Pushed for 24.11!

Well done everyone, thank you!