Like bug 36821, but for MARC bibliographic frameworks. The database columns for liblibrarian and libopac in marc_tag_structure and marc_subfield_structure are 255 characters, but the HTML maxlength in /koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt and /koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt limit tags to 100 characters and subfields to 80 characters.
Created attachment 171108 [details] [review] Bug 37293: MARC bibliographic framework text for librarians and OPAC limited to 100 characters The database columns for liblibrarian and libopac in marc_tag_structure and marc_subfield_structure are 255 characters, but the HTML maxlength in /koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt and /koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt limit tags to 100 characters and subfields to 80 characters. Test plan: 1. Apply patch, restart_all 2. Administration - MARC bibliographic framework - for Default, Actions - MARC Structure 3. For the 000 tag, Actions - Edit tag 4. In both the "Description in staff interface" and "Description in OPAC" paste the 255 character string 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 12 and click Save changes 5. Verify that the display shows all 255 characters, then Actions - Edit tag and verify that the two inputs reloaded with all 255 characters, and that you cannot type a 256th character, then click Cancel 6. For the 000 tag, Actions - Edit subfields 7. Paste the same string in both the staff interface and OPAC inputs, Save changes, verify that all 255 characters show, click Edit subfields, verify that all 255 characters reloaded in the inputs, verify that you cannot type a 256th character Sponsored-by: Chetco Community Public Library
Created attachment 172061 [details] [review] Bug 37293: MARC bibliographic framework text for librarians and OPAC limited to 100 characters The database columns for liblibrarian and libopac in marc_tag_structure and marc_subfield_structure are 255 characters, but the HTML maxlength in /koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt and /koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt limit tags to 100 characters and subfields to 80 characters. Test plan: 1. Apply patch, restart_all 2. Administration - MARC bibliographic framework - for Default, Actions - MARC Structure 3. For the 000 tag, Actions - Edit tag 4. In both the "Description in staff interface" and "Description in OPAC" paste the 255 character string 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 12 and click Save changes 5. Verify that the display shows all 255 characters, then Actions - Edit tag and verify that the two inputs reloaded with all 255 characters, and that you cannot type a 256th character, then click Cancel 6. For the 000 tag, Actions - Edit subfields 7. Paste the same string in both the staff interface and OPAC inputs, Save changes, verify that all 255 characters show, click Edit subfields, verify that all 255 characters reloaded in the inputs, verify that you cannot type a 256th character Sponsored-by: Chetco Community Public Library Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com>
Switching from enh per bug 36821 comment 9
Created attachment 174952 [details] [review] Bug 37293: MARC bibliographic framework text for librarians and OPAC limited to 100 characters The database columns for liblibrarian and libopac in marc_tag_structure and marc_subfield_structure are 255 characters, but the HTML maxlength in /koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt and /koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt limit tags to 100 characters and subfields to 80 characters. Test plan: 1. Apply patch, restart_all 2. Administration - MARC bibliographic framework - for Default, Actions - MARC Structure 3. For the 000 tag, Actions - Edit tag 4. In both the "Description in staff interface" and "Description in OPAC" paste the 255 character string 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 12 and click Save changes 5. Verify that the display shows all 255 characters, then Actions - Edit tag and verify that the two inputs reloaded with all 255 characters, and that you cannot type a 256th character, then click Cancel 6. For the 000 tag, Actions - Edit subfields 7. Paste the same string in both the staff interface and OPAC inputs, Save changes, verify that all 255 characters show, click Edit subfields, verify that all 255 characters reloaded in the inputs, verify that you cannot type a 256th character Sponsored-by: Chetco Community Public Library Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed for 25.05! Well done everyone, thank you!
Nice work everyone! Pushed to 24.11.x for 24.11.01
Backported to 24.05.x for 24.05.06
Pushed to 23.11.x for 23.11.11