Bug 37300 - Unable to modify certain items in biblio detail page
Summary: Unable to modify certain items in biblio detail page
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Emmi Takkinen
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-10 08:08 UTC by Emmi Takkinen
Modified: 2024-07-12 15:35 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 37300: Allow modifying holds from any library again via biblio detail page (1.91 KB, patch)
2024-07-10 10:05 UTC, Emmi Takkinen
Details | Diff | Splinter Review
Bug 37300: Allow modifying holds from any library again via biblio detail page (2.71 KB, patch)
2024-07-12 10:47 UTC, Emmi Takkinen
Details | Diff | Splinter Review
Bug 37300: Allow modifying holds from any library again via biblio detail page (2.76 KB, patch)
2024-07-12 15:34 UTC, ByWater Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emmi Takkinen 2024-07-10 08:08:19 UTC
Bug 33568 introduced use of REST API to display items on biblio detail page. Because changes made in the bug ability to modifying item is now tied to items hold library when previously this was based on if patrons home library and items home library match. This happens even if patron is superlibrarian or syspref IndependentBranches is turned off.

To reproduce:
1. Find biblio with items from library A and B.
2. Change one items holding branch to branch C (either manually from database or transfer item through Koha).
3. Note that you can no longer modify this item.
Comment 1 Emmi Takkinen 2024-07-10 10:05:28 UTC
Created attachment 168705 [details] [review]
Bug 37300: Allow modifying holds from any library again via biblio detail page

Currently one can no longer select item to be modified from
biblio detail page if items hold library differs from users
home library and home libraries of all items. Previously
this was possible. This patch reintroduces this functionality.

To test:
1. Find biblio with items from library A and B.
2. Change one items holding branch to branch C (either
manually from database or transfer item through Koha).
=> Note that you can no longer select this item and
its row has no "Edit" button on it.
3. Apply this patch.
4. Refresh page.
=> You can now select item and "Edit" button is displayed.

Sponsored-by: Koha-Suomi Oy
Comment 2 Esther Melander 2024-07-11 16:21:55 UTC
I tested this. I was able to select the item with the check box and then click on modify the selected item. However, the edit button at the end of the row still disappears.
Comment 3 Emmi Takkinen 2024-07-12 10:47:05 UTC
Created attachment 168890 [details] [review]
Bug 37300: Allow modifying holds from any library again via biblio detail page

Currently one can no longer select item to be modified from
biblio detail page if items hold library differs from users
home library and home libraries of all items. Previously
this was possible. This patch reintroduces this functionality.

To test:
1. Find biblio with items from library A and B.
2. Change one items holding branch to branch C (either
manually from database or transfer item through Koha).
=> Note that you can no longer select this item and
its row has no "Edit" button on it.
3. Apply this patch.
4. Refresh page.
=> You can now select item and "Edit" button is displayed.

Sponsored-by: Koha-Suomi Oy
Comment 4 Emmi Takkinen 2024-07-12 10:51:41 UTC
(In reply to Esther Melander from comment #2)
> I tested this. I was able to select the item with the check box and then
> click on modify the selected item. However, the edit button at the end of
> the row still disappears.

Thank you for testing this! Edit button should know also be visible.
Comment 5 ByWater Sandboxes 2024-07-12 15:34:47 UTC
Created attachment 168921 [details] [review]
Bug 37300: Allow modifying holds from any library again via biblio detail page

Currently one can no longer select item to be modified from
biblio detail page if items hold library differs from users
home library and home libraries of all items. Previously
this was possible. This patch reintroduces this functionality.

To test:
1. Find biblio with items from library A and B.
2. Change one items holding branch to branch C (either
manually from database or transfer item through Koha).
=> Note that you can no longer select this item and
its row has no "Edit" button on it.
3. Apply this patch.
4. Refresh page.
=> You can now select item and "Edit" button is displayed.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Esther <esther@bywatersolutions.com>
Comment 6 Esther Melander 2024-07-12 15:35:56 UTC
The edit button and the checkbox - modify selected item are working now!